Add UMX SlowBuildRepro repository to test matrix #19170
Draft
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
T-Gro
commented
Dec 18, 2025
Comment on lines
893
to
+899
| - template: /eng/templates/regression-test-jobs.yml | ||
| parameters: | ||
| testMatrix: | ||
| - repo: marklam/SlowBuildRepro | ||
| commit: bbe2dec4d0379b5d7d0480997858c30d442fbb42 | ||
| buildScript: dotnet build | ||
| displayName: UMX_Slow_Repro |
Member
Author
There was a problem hiding this comment.
Change the logic inside regression-test-jobs.yml to allow a missing dedicated script, so that we can support plain passing of dotnet build as a command as well.
Option to pass in a dedicated script will remain there.
Consider any of the "dotnet" commands (lets say starting with "dotnet") as built in and not needing another validation.
Contributor
* Initial plan * Support built-in dotnet commands in regression test template Modified regression-test-jobs.yml to: - Skip file validation for commands starting with "dotnet" - Execute dotnet commands directly using Invoke-Expression - Maintain existing file-based script support - Handle both Windows and Linux scenarios appropriately This allows tests like UMX_Slow_Repro to use "dotnet build" directly without requiring a build script file. Co-authored-by: T-Gro <[email protected]> * Add security clarification comments for buildScript usage Added comments to clarify that buildScript comes from pipeline YAML configuration, not external user input, making Invoke-Expression safe in this context. Co-authored-by: T-Gro <[email protected]> * Execute provided buildScript on Windows instead of hardcoded build.proj Changed Windows file-based script execution to use the provided buildScript parameter instead of assuming build.proj exists. Now Windows behavior matches Linux - it executes the actual script specified in the configuration. Co-authored-by: T-Gro <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: T-Gro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.