Metadata handling improvements #3861
Open
+147
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix the issue of outputs disappearing when opening a notebook and also .ipynb files immediately being marked dirty on open. That issue is still present for .dib files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the following issues:
This is a work in progress and additional PRs will continue to investigate and address some of the
FIXcomments present here but this is likely worth merging in order to do a preview release and validate the changes against a larger number of existing notebook documents than the tests likely account for. I anticipate that some of these changes will break backwards compatibility for metadata variations that date back to before the VS Code notebook APIs were finalized. I don't believe it's practical to support those forever, and any notebooks that are broken as a result will at this point be far fewer than the impact of these bugs on newer and newly-created notebooks.