-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Target net9.0 #1279
Merged
[build] Target net9.0 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02786d6
to
303597e
Compare
Requires: dotnet/runtime#109579 …against .NET 9. |
Additionally produces the following trimmer errors:
|
This still fails on .NET 9.0.1. It looks like the backport should be in 9.0.2: |
Time to revisit this now that .NET 9.0.2 shipped? |
Most of these callsites are not called on Android anyway. We can silence them as a way to not introduce new warnings.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Draft commit message: Context: 356485ee41fb61570e84c11ba120d6f8cf81ae09
Context: https://github.com/dotnet/java-interop/issues/1258
Context: https://github.com/dotnet/android/pull/9793
We want to add a call to [Debugger.BreakForUserUnhandledException][0]
-- which was added in .NET 9 -- into `Java.Interop.JniRuntime` as
part of Issues #1258.
In order to do this we need to update `dotnet/java-interop` to build
with .NET 9 instead of .NET 8.
This also contains fixes for new trimming warnings that were surfaced
when targeting .NET 9.
Requires companion changes in `dotnet/android`: dotnet/android#9793
[0]: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.debugger.breakforuserunhandledexception |
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 19, 2025
Changes: dotnet/java-interop@2a7183a...f30e420 * dotnet/java-interop@f30e420a: [build] Target net9.0 (dotnet/java-interop#1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add a call to Debugger.BreakForUserUnhandledException (which was added in .NET 9) in
Java.Interop.JniRuntime
as part of #1258.In order to do this we need to update
java-interop
to be based on .NET 9 instead of .NET 8.Contains fixes for new trimming warnings that were surfaced when targeting .NET 9.
Requires companion changes in
dotnet/android
: dotnet/android#9793.