[generator] Avoid non-blittable types in native callback methods #1296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1027
To make marshaling callbacks from Java easier we should avoid non-blittable types in native callback methods. This means we should marshal
bool
assbyte
andchar
asushort
.generator
has built in support for conversions when the native type does not match the managed type. (ISymbol.[To|From]Native
). However this affects marshaling both ways: managed to Java and Java to managed. We do not want to affect managed to Java marshaling, so we introduce a newISymbol.OnlyFormatOnMarshal
property to control this.This also requires some changes in
dotnet\android
via this PR: dotnet/android#9724.