Skip to content

Commit c0be8bc

Browse files
authored
[xcode26.0] Bump to Xcode 26 Stable (#23819)
2 parents 95cb8c5 + dd844b5 commit c0be8bc

File tree

3 files changed

+18
-8
lines changed

3 files changed

+18
-8
lines changed

Make.config

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ MACCATALYST_NUGET_VERSION_FULL=$(MACCATALYST_NUGET_VERSION_NO_METADATA)$(NUGET_B
202202

203203
# Xcode version should have both a major and a minor version (even if the minor version is 0)
204204
XCODE_VERSION=26.0
205-
XCODE_URL=https://dl.internalx.com/internal-files/xcodes/Xcode_26_Release_Candidate.xip
206-
XCODE_DEVELOPER_ROOT=/Applications/Xcode_26.0.0-rc.app/Contents/Developer
205+
XCODE_URL=https://dl.internalx.com/internal-files/xcodes/Xcode_26.xip
206+
XCODE_DEVELOPER_ROOT=/Applications/Xcode_26.0.0.app/Contents/Developer
207207
XCODE_PRODUCT_BUILD_VERSION:=$(shell /usr/libexec/PlistBuddy -c 'Print :ProductBuildVersion' $(XCODE_DEVELOPER_ROOT)/../version.plist 2>/dev/null || echo " $(shell tput setaf 1 2>/dev/null)The required Xcode ($(XCODE_VERSION)) is not installed in $(basename $(basename $(XCODE_DEVELOPER_ROOT)))$(shell tput sgr0 2>/dev/null)" >&2)
208208

209209
# We define stable Xcode as the Xcode app being named like "Xcode_#.#[.#].app"

system-dependencies.sh

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ function xcodebuild_download_selected_platforms ()
319319
local XCODE_DEVELOPER_ROOT
320320
local XCODE_NAME
321321
local XCODE_IS_STABLE
322+
local XCODE_VERSION
322323
local IOS_NUGET_OS_VERSION
323324
local IOS_BUILD_VERSION
324325
local TVOS_NUGET_OS_VERSION
@@ -328,14 +329,23 @@ function xcodebuild_download_selected_platforms ()
328329
XCODE_NAME=$(basename "$(dirname "$(dirname "$XCODE_DEVELOPER_ROOT")")")
329330
# we use the same logic here as in Make.config to determine whether we're using a stable version of Xcode or not (search for XCODE_IS_STABLE/XCODE_IS_PREVIEW)
330331
XCODE_IS_STABLE=$(echo "$XCODE_NAME" | sed -e 's@^Xcode[_0-9.]*[.]app$@YES@')
332+
XCODE_VERSION=$(grep ^XCODE_VERSION= Make.config | sed 's/.*=//')
331333

332334
IOS_BUILD_VERSION=
333335
TVOS_BUILD_VERSION=
334-
if [[ "$XCODE_IS_STABLE" == "YES" ]]; then
335-
IOS_NUGET_OS_VERSION=$(grep '^IOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
336-
IOS_BUILD_VERSION=" -buildVersion $IOS_NUGET_OS_VERSION"
337-
TVOS_NUGET_OS_VERSION=$(grep '^TVOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
338-
TVOS_BUILD_VERSION=" -buildVersion $TVOS_NUGET_OS_VERSION"
336+
if is_at_least_version "$XCODE_VERSION" 26.1; then
337+
# passing -buildVersion .. --architectureVariant .. doesn't quite work in Xcode 26.0 (it works the first time, but then it always thinks it's the first time, tries to download and install, and gets confused), let's see if they fix it in Xcode 26.1
338+
if [[ "$XCODE_IS_STABLE" == "YES" ]]; then
339+
if [[ "$(arch)" == "arm64" ]]; then
340+
ARCHITECTURE_VARIANT=arm64
341+
else
342+
ARCHITECTURE_VARIANT=universal
343+
fi
344+
IOS_NUGET_OS_VERSION=$(grep '^IOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
345+
IOS_BUILD_VERSION=" -buildVersion $IOS_NUGET_OS_VERSION -architectureVariant $ARCHITECTURE_VARIANT"
346+
TVOS_NUGET_OS_VERSION=$(grep '^TVOS_NUGET_OS_VERSION=' Make.versions | sed 's/.*=//')
347+
TVOS_BUILD_VERSION=" -buildVersion $TVOS_NUGET_OS_VERSION -architectureVariant $ARCHITECTURE_VARIANT"
348+
fi
339349
fi
340350

341351
log "Executing '$XCODE_DEVELOPER_ROOT/usr/bin/xcodebuild -downloadPlatform iOS$IOS_BUILD_VERSION' $1"

tools/devops/automation/templates/variables/common.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,4 @@ variables:
7474
value: 15.6
7575

7676
- name: xcodeChannel
77-
value: Beta
77+
value: Stable

0 commit comments

Comments
 (0)