[RGen] Use the 'global::' alias for all types. #22885

mandel-macaque · 2025-05-23T01:26:46Z

Update the code generation of rgen to use the 'global::' alias based in the generator configuration. The tests classes have been updated to ensure that if we switch off the use of the alias, the tests do not need to be updated.

Upate the code generation of rgen to use the 'global::' allias based in the generator configuration. The tests classes have been updated to ensure that if we switch off the use of the alias, the tests do not need to be udpdated.

mandel-macaque · 2025-05-23T01:33:14Z

tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/iOSExpectedPropertyTests.cs

 	[SupportedOSPlatform ("maccatalyst13.1")]
 	[BindingImpl (BindingImplOptions.GeneratedCode | BindingImplOptions.Optimizable)]
-	public virtual partial nfloat LineSpacing
+	public virtual partial global::CompareGeneratedCode.CompareGeneratedCode.netmodule..nfloat LineSpacing


This is wrong, missing the global using. Will fix it.

Copilot

Pull Request Overview

This PR updates the RGen code generator to support toggling the global:: alias for all generated type references via configuration.

Introduces a $GLOBAL$ placeholder in test fixtures and a isGlobal flag to replace it at read time
Adds StringExtensions.GetIdentifierName and refactors emitters/formatters to build TypeSyntax directly
Enhances TypeInfo with init-only properties and conversion helpers for array/non-nullable types

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/rgen/.../ExpectedAVAudioPcmBufferNoDefaultCtr.cs	Switched `global::` placeholder for ObjCRuntime calls
tests/rgen/.../ExpectedAVAudioPcmBufferDefaultCtr.cs	Updated default ctor to use `global::` alias for Foundation types
tests/rgen/.../BindingSourceGeneratorGeneratorTests.cs	Adjusted test to expect `global::` in class handle
tests/rgen/.../BaseTestDataGenerator.cs	Added `isGlobal` flag and placeholder replacement logic
tests/rgen/.../BaseGeneratorTestClass.cs	Added `Global(string)` helper to prefix with `global::`
src/rgen/.../Microsoft.Macios.Transformer.csproj	Linked `Configuration.cs` and `ArgumentSyntaxExtensions.cs`
src/rgen/.../TypeInfoFormatter.cs	Refactored identifier building to use `GetIdentifierName`
src/rgen/.../StringExtensions.cs	Added `GetIdentifierName` extension for qualified names
src/rgen/.../ArgumentSyntaxExtensions.cs	Removed unused using and aligned imports
src/rgen/.../EnumEmitter.cs	Refactored error-domain emitter to use `NSString` & `Dlfcn`
src/rgen/.../ClassEmitter.cs	Updated default-ctor emission to use qualified `NSObjectFlag`
src/rgen/.../BindingSyntaxFactory.cs	Changed `StaticVariable` and invocations to accept `TypeSyntax`
src/rgen/.../BindingSyntaxFactory.Trampoline.cs	Switched pointer/generic calls to use `GetIdentifierSyntax`
src/rgen/.../BindingSyntaxFactory.Runtime.cs	Updated various `Get*` methods to take `TypeSyntax`
src/rgen/.../BindingSyntaxFactory.Property.cs	Refactored property binding to use `GetIdentifierName`
src/rgen/.../BindingSyntaxFactory.ObjCRuntime.cs	Expanded and reorganized known ObjCRuntime/Foundation types
src/rgen/.../BindingSyntaxFactory.Dlfcn.cs	Switched Dlfcn/Libraries fields to use `GetIdentifierName`
src/rgen/.../DataModel/TypeInfo.cs	Made several props `init`-only; added `ToArrayElementType`/`ToNonNullable`
src/rgen/.../Microsoft.Macios.Bindings.Analyzer.csproj	Linked `Configuration.cs` and `ArgumentSyntaxExtensions.cs`

Copilot · 2025-05-23T01:36:06Z

tests/rgen/Microsoft.Macios.Generator.Tests/BaseTestDataGenerator.cs

+		return isGlobal
+			? File.ReadAllText (fullPath).Replace ("$GLOBAL$", "global::")
+			: File.ReadAllText (fullPath).Replace ("$GLOBAL$", "");


The code invokes File.ReadAllText twice depending on isGlobal. Consider reading the file into a local variable once and then applying .Replace(...) to avoid duplicate I/O.

Suggested change

return isGlobal

? File.ReadAllText (fullPath).Replace ("$GLOBAL$", "global::")

: File.ReadAllText (fullPath).Replace ("$GLOBAL$", "");

var fileContent = File.ReadAllText(fullPath);

return isGlobal

? fileContent.Replace("$GLOBAL$", "global::")

: fileContent.Replace("$GLOBAL$", "");

It's an if unary operator, only one branch executes.

Copilot · 2025-05-23T01:36:06Z

src/rgen/Microsoft.Macios.Generator/DataModel/TypeInfo.cs

 		return type;
 	}

+	public TypeInfo ToArrayElementType ()


The ToArrayElementType helper resets IsArray and SpecialType but does not update Name or Namespace to the element type. This will lead to incorrect type names downstream. It should also set Name and Namespace based on the element type.

The comment is incorrect, we do the following:

if (symbol is IArrayTypeSymbol arraySymbol) { // override the name and namespace with the array name (Name, Namespace) = GetTypeNameAndNamespace (arraySymbol.ElementType); FullyQualifiedName = arraySymbol.ElementType.ToDisplayString (); IsArray = true; ArrayElementType = arraySymbol.ElementType.SpecialType; ArrayElementTypeIsWrapped = arraySymbol.ElementType.IsWrapped (); ArrayElementIsINativeObject = arraySymbol.ElementType.IsINativeObject (); }

which avoids the issue. Good try.

src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.Dlfcn.cs

…er tracking.

…ppends with nfloat.

…ory.Dlfcn.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2025-05-23T15:37:04Z

✅ [CI Build #4732f46] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4732f469e4d5e4528d6f5a99f7954e0b692ad5b5 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T15:46:41Z

✅ [PR Build #c0160ed] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c0160ed8845264ed70e1d5210701e15f7c64de4b [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T16:23:20Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c0160ed8845264ed70e1d5210701e15f7c64de4b [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T16:25:15Z

✅ [CI Build #0bfe739] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0bfe7392e794bb1ff547184bf717a756e4af1d9d [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T16:36:39Z

💻 [CI Build #0bfe739] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0bfe7392e794bb1ff547184bf717a756e4af1d9d [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T16:39:17Z

💻 [CI Build #0bfe739] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0bfe7392e794bb1ff547184bf717a756e4af1d9d [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T16:41:06Z

💻 [CI Build #0bfe739] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0bfe7392e794bb1ff547184bf717a756e4af1d9d [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T16:52:01Z

💻 [CI Build #c0160ed] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c0160ed8845264ed70e1d5210701e15f7c64de4b [PR build]

vs-mobiletools-engineering-service2 · 2025-05-23T18:27:07Z

🔥 [CI Build #0bfe739] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 15 tests failed, 110 tests passed.

Failures

❌ monotouch tests (MacCatalyst)

15 tests failed, 0 tests passed.

Details

monotouch-test/Mac Catalyst/Debug: Failed (Test run failed.
Tests run: 3205 Passed: 3065 Inconclusive: 10 Failed: 1 Ignored: 139)
monotouch-test/Mac Catalyst/Debug (ARM64): Failed (Test run failed.
Tests run: 3205 Passed: 3065 Inconclusive: 10 Failed: 1 Ignored: 139)
monotouch-test/Mac Catalyst/Debug (managed static registrar): Failed (Test run failed.
Tests run: 3202 Passed: 3064 Inconclusive: 10 Failed: 1 Ignored: 137)
monotouch-test/Mac Catalyst/Debug (static registrar): Failed (Test run crashed (exit code: 139).
Test run crashed)
monotouch-test/Mac Catalyst/Debug (static registrar, ARM64): Failed (Test run failed.
Tests run: 3202 Passed: 3064 Inconclusive: 10 Failed: 1 Ignored: 137)
monotouch-test/Mac Catalyst/Release (managed static registrar): Failed (Test run failed.
Tests run: 3202 Passed: 3059 Inconclusive: 10 Failed: 1 Ignored: 142)
monotouch-test/Mac Catalyst/Release (managed static registrar, all optimizations): Failed (Test run failed.
Tests run: 3202 Passed: 3059 Inconclusive: 10 Failed: 1 Ignored: 142)
monotouch-test/Mac Catalyst/Release (NativeAOT): Failed (Test run failed.
Tests run: 3202 Passed: 3047 Inconclusive: 11 Failed: 1 Ignored: 154)
monotouch-test/Mac Catalyst/Release (NativeAOT, ARM64): Failed (Test run failed.
Tests run: 3202 Passed: 3049 Inconclusive: 10 Failed: 1 Ignored: 152)
monotouch-test/Mac Catalyst/Release (NativeAOT, x64): Failed (Test run failed.
Tests run: 3202 Passed: 3056 Inconclusive: 11 Failed: 1 Ignored: 145)
monotouch-test/Mac Catalyst/Release (static registrar): Failed (Test run failed.
Tests run: 3202 Passed: 3058 Inconclusive: 10 Failed: 1 Ignored: 143)
monotouch-test/Mac Catalyst/Release (static registrar, all optimizations): Failed (Test run failed.
Tests run: 3202 Passed: 3059 Inconclusive: 10 Failed: 1 Ignored: 142)
monotouch-test/Mac Catalyst/Release (ARM64, LLVM): Failed (Test run failed.
Tests run: 3202 Passed: 3059 Inconclusive: 10 Failed: 1 Ignored: 142)
monotouch-test/Mac Catalyst/Debug (interpreter): Failed (Test run failed.
Tests run: 3205 Passed: 3062 Inconclusive: 10 Failed: 1 Ignored: 142)
monotouch-test/Mac Catalyst/Release (interpreter): Failed (Test run failed.
Tests run: 3202 Passed: 3056 Inconclusive: 10 Failed: 1 Ignored: 145)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0bfe7392e794bb1ff547184bf717a756e4af1d9d [PR build]

mandel-macaque · 2025-05-23T19:20:51Z

Failures are unrelated to code changes.

mandel-macaque and others added 2 commits May 22, 2025 21:23

[RGen] Use the 'global::' alias for all types.

0b67591

Upate the code generation of rgen to use the 'global::' allias based in the generator configuration. The tests classes have been updated to ensure that if we switch off the use of the alias, the tests do not need to be udpdated.

Auto-format source code

49916a3

mandel-macaque commented May 23, 2025

View reviewed changes

dalexsoto requested a review from Copilot May 23, 2025 01:34

Copilot AI reviewed May 23, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes May 23, 2025

View reviewed changes

src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.Dlfcn.cs Outdated Show resolved Hide resolved

mandel-macaque and others added 5 commits May 23, 2025 10:26

Do not require to do the ToArray when trying to get the type expression.

0de9cd7

Move all the TypeSyntaxt of known types to the same location for easi…

55e372f

…er tracking.

Fix the case in which we need a using rename in the bindings. This ha…

0bfe739

…ppends with nfloat.

Auto-format source code

c0160ed

Update src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFact…

4732f46

…ory.Dlfcn.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 4e6e475 into main May 23, 2025
44 checks passed

mandel-macaque deleted the dev/mandel/global-all-the-things branch May 23, 2025 19:20

[RGen] Use the 'global::' alias for all types. #22885

[RGen] Use the 'global::' alias for all types. #22885

Uh oh!

Conversation

mandel-macaque commented May 23, 2025 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandel-macaque May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

mandel-macaque May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

mandel-macaque May 23, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 23, 2025

✅ [CI Build #4732f46] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 23, 2025

✅ [PR Build #c0160ed] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 23, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 23, 2025

✅ [CI Build #0bfe739] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 23, 2025

💻 [CI Build #0bfe739] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 23, 2025

mandel-macaque commented May 23, 2025 •

edited by rolfbjarne

Loading

mandel-macaque May 23, 2025 •

edited

Loading