[msbuild/dotnet] Remove appextension-specific targets and props files. #23602
Conversation
Pending: the actual fix. For now this only has a test. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.
…ns. Fixes #23516. Don't override the GetTargetPath/Build/Rebuild targets for app extensions, because we also override some of these targets when building remotely, and the custom logic for app extensions is overridden. Instead create new targets that depend on those we previously override instead. Fixes #23516.
As these operations just read/write items from/to an XML file, this is something we don't need to run remotely when building from Windows. This improves the build performance and also fixes some inconsistencies we had were sometimes files were written locally and read remotely (or the other way around).
Some files are written remotely as part of other tasks (not through WriteItemsToFile), like the linker outputs (Illink).
They're not needed anymore.
✅ [CI Build #95dc5d6] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #95dc5d6] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #95dc5d6] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #95dc5d6] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #95dc5d6] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #95dc5d6] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #95dc5d6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🔥 [CI Build #95dc5d6] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 119 tests passed. Failures❌ windows testsHtml Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
force-pushed
the
dev/rolf/fix-building-extensions-on-remote-windows
branch
from
8262d57 to
f33d81e
Compare
3 participants
They're not needed anymore.