Skip to content

[devops] Fix hiding comments. #23661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 9 commits into from
Sep 11, 2025
Merged

[devops] Fix hiding comments. #23661

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
991607e
[devops] Fix hiding comments.
rolfbjarne Aug 21, 2025
b66f297
Merge branch 'main' into dev/rolf/devops-fix-comment-hiding
rolfbjarne Sep 9, 2025
6de543a
Add more debug spew.
rolfbjarne Sep 10, 2025
9492a87
Try node id
rolfbjarne Sep 10, 2025
9ba4dcb
More debug spew.
rolfbjarne Sep 11, 2025
13d63af
second commit
rolfbjarne Sep 11, 2025
27e9ba6
Success now?
rolfbjarne Sep 11, 2025
081721e
Merge remote-tracking branch 'origin/main' into dev/rolf/devops-fix-c…
rolfbjarne Sep 11, 2025
159df40
Remove debug spew
rolfbjarne Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/devops/automation/scripts/GitHub.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ mutation {
Write-Host "Current commit is not the latest in PR, attempting to hide the new comment"
try {
Start-Sleep -Seconds 2 # Give GitHub a moment to process the comment
$this.MinimizeCommentId($result.id)
$this.MinimizeCommentId($result.node_id)
} catch {
Write-Host "Warning: Failed to hide comment for non-latest commit: $_"
}
Expand Down