Skip to content

[RGen] Add validations for the BindingType attribute for a Category. #23798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev/mandel/category-no-property-no-constructor
Choose a base branch
from
Open

[RGen] Add validations for the BindingType attribute for a Category. #23798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bf39c9
[RGen] Add validations for the BindingType attribute for a Category.
mandel-macaque Sep 11, 2025
7ce4c2e
Auto-format source code
Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
189 changes: 189 additions & 0 deletions src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

91 changes: 91 additions & 0 deletions src/rgen/Microsoft.Macios.Bindings.Analyzer/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,4 +638,95 @@
<value>Properties are not supported on categories</value>
</data>

<!-- RBI0048 -->

<data name="RBI0048Description" xml:space="preserve">
<value>A category name cannot be an empty string or have spaces.</value>
</data>
<data name="RBI0048MessageFormat" xml:space="preserve">
<value>Category '{0}' name '{1}' is empty an empty string or has white spaces</value>
<comment>{0} is the name of the category, {1} is what we found</comment>
</data>
<data name="RBI0048Title" xml:space="preserve">
<value>Category names cannot be a empty string or have white spaces</value>
</data>

<!-- RBI0049 -->

<data name="RBI0049Description" xml:space="preserve">
<value>A category type must be a INativeObject.</value>
</data>
<data name="RBI0049MessageFormat" xml:space="preserve">
<value>Category '{0}' type '{1}' does not implement INativeObject</value>
<comment>{0} is the name of the category, {1} is the category type</comment>
</data>
<data name="RBI0049Title" xml:space="preserve">
<value>Category types must be INativeObjects</value>
</data>

<!-- RBI0050 -->

<data name="RBI0050Description" xml:space="preserve">
<value>DefaultCtorVisibility is ignored in categories.</value>
</data>
<data name="RBI0050MessageFormat" xml:space="preserve">
<value>Category '{0}' has DefaultCtorVisibility set to '{1}' but it will be ignored</value>
<comment>{0} is the name of the category, {1} is the value</comment>
</data>
<data name="RBI0050Title" xml:space="preserve">
<value>DefaultCtorVisibility is ignored in categories</value>
</data>

<!-- RBI0051 -->

<data name="RBI0051Description" xml:space="preserve">
<value>ErrorDomain is ignored in categories.</value>
</data>
<data name="RBI0051MessageFormat" xml:space="preserve">
<value>Category '{0}' has ErrorDomain set to '{1}' but it will be ignored</value>
<comment>{0} is the name of the category, {1} is the value</comment>
</data>
<data name="RBI0051Title" xml:space="preserve">
<value>ErrorDomain is ignored in categories</value>
</data>

<!-- RBI0052 -->

<data name="RBI0052Description" xml:space="preserve">
<value>IntPtrCtorVisibility is ignored in categories.</value>
</data>
<data name="RBI0052MessageFormat" xml:space="preserve">
<value>Category '{0}' has IntPtrCtorVisibility set to '{1}' but it will be ignored</value>
<comment>{0} is the name of the category, {1} is the value</comment>
</data>
<data name="RBI0052Title" xml:space="preserve">
<value>IntPtrCtorVisibility is ignored in categories</value>
</data>

<!-- RBI0053 -->

<data name="RBI0053Description" xml:space="preserve">
<value>ModelName is ignored in categories.</value>
</data>
<data name="RBI0053MessageFormat" xml:space="preserve">
<value>Category '{0}' has ModelName set to '{1}' but it will be ignored</value>
<comment>{0} is the name of the category, {1} is the value</comment>
</data>
<data name="RBI0053Title" xml:space="preserve">
<value>ModelName is ignored in categories</value>
</data>

<!-- RBI0054 -->

<data name="RBI0054Description" xml:space="preserve">
<value>StringCtorVisibility is ignored in categories.</value>
</data>
<data name="RBI0054MessageFormat" xml:space="preserve">
<value>Category '{0}' has StringCtorVisibility set to '{1}' but it will be ignored</value>
<comment>{0} is the name of the category, {1} is the value</comment>
</data>
<data name="RBI0054Title" xml:space="preserve">
<value>StringCtorVisibility is ignored in categories</value>
</data>

</root>
Loading