[RGen] Track if a type inherits from NSCoder or implements INSCoder. #23802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows later to access this information for the analyzer and the code generator. In a later PR we will track if the type implements the NSCoder interface and will generate a number of default constructors when needed.
This will later be used for the analyzer to let the user know that the initWithCoder: constructor is missing.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
✅ [CI Build #f223b6c] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [PR Build #f223b6c] Build passed (Detect API changes) ✅Pipeline on Agent |
…cios into dev/mandel/is-nscoder
rolfbjarne
requested changes
Sep 12, 2025
| const string dictionaryContainerClass = "Foundation.DictionaryContainer"; | ||
| const string uiViewClass = "UIKit.UIView"; | ||
| const string appKitViewClass = "AppKit.NSView"; | ||
| const string nsCodingClass = "Foundation.NSCoding"; |
Member
There was a problem hiding this comment.
Only the interface (INSCoding) makes sense to check for, nobody should subclass the class (NSCoding).
Contributor
Author
There was a problem hiding this comment.
why do we do that check in bgen?
Member
There was a problem hiding this comment.
Probably historical reasons would be my guess
Contributor
Author
|
Closing this to take a more generic approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will later be used for the analyzer to let the user know that the initWithCoder: constructor is missing.