Skip to content

[Foundation] Avoid calling ToString more than once on headers and their values. #23825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Sep 17, 2025
Merged

[Foundation] Avoid calling ToString more than once on headers and their values. #23825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a482948
[Foundation] Avoid calling ToString more than once on headers and the…
rolfbjarne Sep 16, 2025
c72d85f
Merge remote-tracking branch 'origin/main' into dev/rolf/perf-nsurlht…
rolfbjarne Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Foundation/NSUrlSessionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,13 +940,16 @@ void DidReceiveResponseImpl (NSUrlSession session, NSUrlSessionDataTask dataTask
httpResponse.RequestMessage.RequestUri = absoluteUri;

foreach (var v in urlResponse.AllHeaderFields) {
var key = v.Key?.ToString ();
var value = v.Value?.ToString ();

// NB: Cocoa trolling us so hard by giving us back dummy dictionary entries
if (v.Key is null || v.Value is null) continue;
if (key is null || value is null) continue;
// NSUrlSession tries to be smart with cookies, we will not use the raw value but the ones provided by the cookie storage
if (v.Key.ToString () == SetCookie) continue;
if (key == SetCookie) continue;

httpResponse.Headers.TryAddWithoutValidation (v.Key.ToString (), v.Value.ToString ());
httpResponse.Content.Headers.TryAddWithoutValidation (v.Key.ToString (), v.Value.ToString ());
httpResponse.Headers.TryAddWithoutValidation (key, value);
httpResponse.Content.Headers.TryAddWithoutValidation (key, value);
}

// it might be confusing that we are not using the managed CookieStore here, this is ONLY for those cookies that have been retrieved from
Expand Down
Loading