[CoreImage] Adjust a little bit how filters are bound and verified. #23987
Conversation
Each CIFilter can desribe their input and output properties (the filter's InputKeys and OutputKeys properties), and also a dictionary with information about these input and output properties (the filter's Attributes property). We've bound the input and output properties in C#, with the help of the information in the dictionary on how to bind them. However, it turns out not every entry in the InputKeys and OutputKeys properties have a corresponding entry in the Attributes dictionary, which makes them hard to bind, because there's no type information we can use to determine how to bind them. Additionally, none of these entries show up in the filter's corresponding protocol either. This leads me to believe we shouldn't bind these input and output properties, so don't do that: * Update introspection to ignore these properties. This means we can remove a few hard-coded skips in the tests. * Remove these properties from the bindings if they're already there (for XAMCORE_5_0). Some were actually there, just commented out, and those got just removed.
✅ [CI Build #95b4882] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #95b4882] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #95b4882] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #95b4882] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #95b4882] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #95b4882] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #95b4882] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #95b4882] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #95b4882] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 115 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
2 participants
Each CIFilter can desribe their input and output properties (the filter's InputKeys
and OutputKeys properties), and also a dictionary with information about these input
and output properties (the filter's Attributes property).
We've bound the input and output properties in C#, with the help of the information
in the dictionary on how to bind them.
However, it turns out not every entry in the InputKeys and OutputKeys properties
have a corresponding entry in the Attributes dictionary, which makes them hard to
bind, because there's no type information we can use to determine how to bind them.
Additionally, none of these entries show up in the filter's corresponding protocol
either.
This leads me to believe we shouldn't bind these input and output properties, so
don't do that:
hard-coded skips in the tests.
Some were actually there, just commented out, and those got just removed.