Skip to content

[net10.0] [dotnet] Don't overwrite any existing value for DOTNET_DiagnosticPorts when computed through our build logic. #23997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

[net10.0] [dotnet] Don't overwrite any existing value for DOTNET_DiagnosticPorts when computed through our build logic. #23997

merged 2 commits into from
Oct 15, 2025

Conversation

rolfbjarne
Copy link
Member

Backport of #23993.

rolfbjarne and others added 2 commits October 14, 2025 14:18
@rolfbjarne
[dotnet] Don't overwrite any existing value for DOTNET_DiagnosticPort…
c75d87d 
…s when computed through our build logic.

Until now, people set the 'DOTNET_DiagnosticPorts' environment variable at
launch/runtime to profile or trace an app.

When we added support for setting specific MSBuild properties to enable
diagnostics (DiagnosticsAddress, DiagnosticsSuspend, etc.), we end up
unconditionally setting the DOTNET_DiagnosticPorts environment variable,
effectively overwriting any value specified by customers when launching the
app.

This meant that existing (and fully functioning) profiling/tracing workflows
would only work if they set the DOTNET_DiagnosticPorts variable to the
defaults we have.

Fix this by allowing overriding DOTNET_DiagnosticPorts variable at launch/runtime.
@rolfbjarne
Auto-format source code
4b59327
@rolfbjarne rolfbjarne changed the title [net10.0] Merge 59373324856010491bfc5e2d01fd1a4d39e199e4 into a8d585a2f51fc6b3659d2de13e39c181744ff99a [net10.0] [dotnet] Don't overwrite any existing value for DOTNET_DiagnosticPorts when computed through our build logic. Oct 14, 2025
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #4b59327] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #4b59327] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #4b59327] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #4b59327] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #4b59327] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #4b59327] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #4b59327] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #4b59327] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #4b59327] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4b59327bd70aadac2eaec0c7941d8871beb2d53d [PR build]

@rolfbjarne rolfbjarne merged commit b75f441 into net10.0 Oct 15, 2025
45 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/backport-pr-23993-net10.0-2025-10-14 branch October 15, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto