[Foundation] Fix nullability in NSLayoutConstraint. #24434

rolfbjarne · 2025-12-12T16:30:13Z

This is file 37 of 47 files with nullability disabled in Foundation.

Changes:

Enabled nullability
Fixed typos in file header ("palattable" -> "palatable", "INc" -> "Inc")
Added proper XML documentation for all public members, replacing "To be added" placeholders
Replaced include directives with inline documentation from NSLayoutConstraint.xml
Made return types nullable where appropriate (AsNumber, FirstAnchor, SecondAnchor)
Made view2 parameter nullable in Create method
Added ArgumentNullException.ThrowIfNull checks for format and viewsAndMetrics parameters
Removed all four [SupportedOSPlatform] attributes from FirstAnchor and SecondAnchor methods (none contained version numbers)
Added see cref attributes for better documentation cross-referencing
Fixed XML formatting and removed unnecessary whitespace

Contributes towards #17285.

This is file 37 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullability - Fixed typos in file header ("palattable" -> "palatable", "INc" -> "Inc") - Added proper XML documentation for all public members, replacing "To be added" placeholders - Replaced include directives with inline documentation from NSLayoutConstraint.xml - Made return types nullable where appropriate (AsNumber, FirstAnchor, SecondAnchor) - Made view2 parameter nullable in Create method - Added ArgumentNullException.ThrowIfNull checks for format and viewsAndMetrics parameters - Removed all four [SupportedOSPlatform] attributes from FirstAnchor and SecondAnchor methods (none contained version numbers) - Added see cref attributes for better documentation cross-referencing - Fixed XML formatting and removed unnecessary whitespace Contributes towards #17285.

Copilot

Pull request overview

This PR enables nullable reference types in NSLayoutConstraint.cs, one of 47 files with nullability disabled in Foundation. The changes include fixing typos in the file header, adding comprehensive XML documentation to replace "To be added" placeholders, making return types and parameters nullable where appropriate based on the underlying binding definitions, adding defensive null checks, and removing unnecessary platform attributes.

Key changes:

Enabled #nullable enable and fixed nullability annotations for return types and parameters
Corrected typos in the file header ("palattable" → "palatable", "INc" → "Inc", "FromVisualLayout" → "FromVisualFormat")
Replaced XML include directives with inline documentation and improved documentation quality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Foundation/NSLayoutConstraint.cs	Enabled nullability, added null checks for `format` and `viewsAndMetrics` parameters, made return types nullable for `AsNumber`, `FirstAnchor`, and `SecondAnchor` methods, made `view2` parameter nullable in `Create` method, replaced placeholder documentation with detailed XML docs, and removed unnecessary `SupportedOSPlatform` attributes
docs/api/UIKit/NSLayoutConstraint.xml	Removed duplicated documentation entries that were inlined into the C# source file

src/Foundation/NSLayoutConstraint.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2025-12-15T09:34:57Z

✅ [CI Build #43da3aa] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T09:57:15Z

✅ [PR Build #43da3aa] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:44:30Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:45:11Z

✅ [CI Build #43da3aa] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:54:58Z

💻 [CI Build #43da3aa] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:56:16Z

💻 [CI Build #43da3aa] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T10:59:27Z

💻 [CI Build #43da3aa] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T11:00:35Z

💻 [CI Build #43da3aa] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T11:02:43Z

💻 [CI Build #43da3aa] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

vs-mobiletools-engineering-service2 · 2025-12-15T16:46:38Z

🚀 [CI Build #43da3aa] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 128 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 43da3aaf17e0262fdebebb955d75d3ff17cdef50 [PR build]

rolfbjarne requested a review from Copilot December 12, 2025 16:30

Copilot started reviewing on behalf of rolfbjarne December 12, 2025 16:30 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

src/Foundation/NSLayoutConstraint.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Dec 13, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Update src/Foundation/NSLayoutConstraint.cs

43da3aa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rolfbjarne enabled auto-merge (squash) December 15, 2025 09:03

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 86004a9 into main Dec 15, 2025
45 checks passed

[Foundation] Fix nullability in NSLayoutConstraint. #24434

[Foundation] Fix nullability in NSLayoutConstraint. #24434

Uh oh!

Conversation

rolfbjarne commented Dec 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ [CI Build #43da3aa] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ [PR Build #43da3aa] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

✅ [CI Build #43da3aa] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #43da3aa] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #43da3aa] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #43da3aa] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #43da3aa] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Dec 15, 2025

💻 [CI Build #43da3aa] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 15, 2025

🚀 [CI Build #43da3aa] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants