[Foundation] Fix nullability in NSConnection. #24438
Conversation
This is file 39 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullability - Added proper XML documentation for all public members, replacing "To be added" placeholders - Added ArgumentNullException.ThrowIfNull checks for string and NSPortNameServer parameters - Added see cref attributes for better documentation cross-referencing - Added paramref attributes for parameter references in remarks - Fixed XML formatting and removed unnecessary whitespace - Documented the relationship between instance and static GetRootProxy methods Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
This PR enables nullable reference types for the NSConnection.cs file in Foundation, which is part of a larger effort to enable nullability across 47 Foundation files. The changes include enabling #nullable, improving XML documentation from placeholder text to meaningful descriptions, and adding null parameter validation checks.
Key changes:
- Enabled nullable reference types by replacing
#nullable disablewith#nullable enable - Enhanced XML documentation for all three GetRootProxy method overloads with detailed summaries, parameter descriptions, return value descriptions, and remarks
- Added
ArgumentNullException.ThrowIfNullchecks for string and NSPortNameServer parameters - Added null-forgiving operator
!toActivator.CreateInstanceresult on line 80
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #264b15b] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #264b15b] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #264b15b] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #264b15b] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #264b15b] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #264b15b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #264b15b] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #264b15b] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #264b15b] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 130 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 39 of 47 files with nullability disabled in Foundation.
Changes:
Contributes towards #17285.