Skip to content

Conversation

@rolfbjarne
Copy link
Member

No description provided.

dalexsoto and others added 30 commits November 6, 2025 14:32
This is file 27 of 47 files with nullability disabled in Foundation.

Changes made:
- Enabled nullable reference types
- Added comprehensive XML documentation for all public operators and methods
- Removed all 'To be added.' placeholders
- Added proper 'see cref' attributes throughout documentation
- Made explicit operator parameters nullable with ArgumentNullException.ThrowIfNull checks
- Fixed grammar and consistency in XML comments
- Added missing parameter documentation

Contributes towards #17285.

---------

Co-authored-by: GitHub Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This pull request updates the following dependencies

## From https://github.com/dotnet/dotnet

- **Subscription**: [7bea2f72-36de-4307-8c02-e200db7ccd92](https://maestro.dot.net/subscriptions?search=7bea2f72-36de-4307-8c02-e200db7ccd92)
- **Build**: [20251209.9](https://dev.azure.com/dnceng/internal/_build/results?buildId=2857769) ([294121](https://maestro.dot.net/channel/5173/github:dotnet:dotnet/build/294121))
- **Date Produced**: December 10, 2025 6:41:45 AM UTC
- **Commit**: [32aba8526ca0c037d185329fe779e8a288e986fc](dotnet/dotnet@32aba85)
- **Branch**: [release/10.0.1xx](https://github.com/dotnet/dotnet/tree/release/10.0.1xx)

- **Dependency Updates**:
  - From [10.0.2 to 10.0.2][1]
     - Microsoft.NET.Runtime.MonoTargets.Sdk
     - Microsoft.NET.ILLink.Tasks
     - Microsoft.NETCore.App.Ref
  - From [10.0.0-beta.25609.106 to 10.0.0-beta.25609.109][1]
     - Microsoft.DotNet.Arcade.Sdk
     - Microsoft.DotNet.Build.Tasks.Feed
     - Microsoft.DotNet.SharedFramework.Sdk
  - From [0.11.5-alpha.25609.106 to 0.11.5-alpha.25609.109][1]
     - Microsoft.DotNet.Cecil
  - From [10.0.2-servicing.25609.106 to 10.0.2-servicing.25609.109][1]
     - Microsoft.NET.ILLink
  - From [10.0.102-servicing.25609.106 to 10.0.102-servicing.25609.109][1]
     - Microsoft.NET.Sdk
  - From [10.0.102 to 10.0.102][1]
     - Microsoft.TemplateEngine.Authoring.Tasks

[1]: dotnet/dotnet@094213b...32aba85
This way we always check for available hard disk space (currently we don't
check for the API Diff pipeline).

---------

Co-authored-by: Copilot <[email protected]>
This pull request updates the following dependencies

## From https://github.com/dotnet/macios

- **Subscription**: [c0371266-dd6f-4959-822b-decc72d2d668](https://maestro.dot.net/subscriptions?search=c0371266-dd6f-4959-822b-decc72d2d668)
- **Build**: [20251210.2](https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=12929639) ([294145](https://maestro.dot.net/channel/3884/github:dotnet:macios/build/294145))
- **Date Produced**: December 10, 2025 11:30:43 AM UTC
- **Commit**: [69e5712](69e5712)
- **Branch**: [release/9.0.1xx](https://github.com/dotnet/macios/tree/release/9.0.1xx)

- **Dependency Updates**:
  - From [26.0.9782 to 26.0.9783][1]
     - Microsoft.iOS.Sdk.net9.0_26.0
     - Microsoft.MacCatalyst.Sdk.net9.0_26.0
     - Microsoft.macOS.Sdk.net9.0_26.0
     - Microsoft.tvOS.Sdk.net9.0_26.0

[1]: 5f56b8d...69e5712
This pull request updates the following dependencies

## From https://github.com/dotnet/dotnet

- **Subscription**: [7bea2f72-36de-4307-8c02-e200db7ccd92](https://maestro.dot.net/subscriptions?search=7bea2f72-36de-4307-8c02-e200db7ccd92)
- **Build**: [20251211.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2858858) ([294323](https://maestro.dot.net/channel/5173/github:dotnet:dotnet/build/294323))
- **Date Produced**: December 11, 2025 3:05:38 PM UTC
- **Commit**: [11af6ee5adad08cf5743e1578eea8c324d482f5e](dotnet/dotnet@11af6ee)
- **Branch**: [release/10.0.1xx](https://github.com/dotnet/dotnet/tree/release/10.0.1xx)

- **Dependency Updates**:
  - From [10.0.2 to 10.0.2][1]
     - Microsoft.NET.Runtime.MonoTargets.Sdk
     - Microsoft.NET.ILLink.Tasks
     - Microsoft.NETCore.App.Ref
  - From [10.0.0-beta.25609.109 to 10.0.0-beta.25611.101][1]
     - Microsoft.DotNet.Arcade.Sdk
     - Microsoft.DotNet.Build.Tasks.Feed
     - Microsoft.DotNet.SharedFramework.Sdk
  - From [0.11.5-alpha.25609.109 to 0.11.5-alpha.25611.101][1]
     - Microsoft.DotNet.Cecil
  - From [10.0.2-servicing.25609.109 to 10.0.2-servicing.25611.101][1]
     - Microsoft.NET.ILLink
  - From [10.0.102-servicing.25609.109 to 10.0.102-servicing.25611.101][1]
     - Microsoft.NET.Sdk
  - From [10.0.102 to 10.0.102][1]
     - Microsoft.TemplateEngine.Authoring.Tasks

[1]: dotnet/dotnet@32aba85...11af6ee
This is file 33 of 47 files with nullability disabled in Foundation.

Changes:
* Enabled nullability by replacing '#nullable disable' with '#nullable enable'
* Removed [SupportedOSPlatform] attributes without version numbers
* Replaced 'To be added' comments with proper XML documentation
* Added comprehensive XML comments for all public members
* Added 'see cref' attributes for type references
* Fixed whitespace in XML comments
* Updated exception handling to use ArgumentNullException.ThrowIfNull
* Added null-forgiving operators where necessary for Runtime.GetINativeObject calls
* Made operator overload parameters and return types nullable where appropriate
* Add more tests.

Contributes towards #17285.
This is file 29 of 47 files with nullability disabled in Foundation.

Changes made:
- Enabled nullable reference types
- Made internal field notificationCenter nullable (NSNotificationCenter?)
- Made ObservedData fields nullable to properly reflect optional values
- Made method parameters nullable where appropriate (fromObject, keys, aName, anObject)
- Replaced ArgumentNullException with ArgumentNullException.ThrowIfNull
- Removed 'To be added.' placeholder documentation
- Added comprehensive XML documentation for all public methods
- Added proper 'see cref' attributes throughout documentation
- Removed unnecessary whitespace in XML comments
- Improved documentation clarity and consistency
- Added missing exception documentation for ArgumentNullException

Contributes towards #17285.

---------

Co-authored-by: GitHub Copilot <[email protected]>
This is file 30 of 47 files with nullability disabled in Foundation.

Changes:
* Enabled nullable reference types
* Removed 'To be added' placeholder comments
* Added comprehensive XML documentation for TxtRecordData property
* Made TxtRecordData property nullable to match generated code

Contributes towards #17285.

---------

Co-authored-by: GitHub Copilot <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request merges the main branch into net11.0, bringing Xcode 26.2 support and various improvements.

  • Xcode version update: Updates from Xcode 26.1 to 26.2 across all configurations and SDK versions
  • API additions: New APIs across multiple Apple frameworks including AuthenticationServices (password management), AVFoundation (edge light, dual route audio), HealthKit (hypertension events), GameKit, GameController, BrowserEngineKit, SafariServices, and PassKit
  • Nullable reference types: Enables nullable reference types in Foundation classes (NSNumber, NSNotificationCenter, NSNetService, NSMutableOrderedSet) with proper null handling
  • Build improvements: Refactors disk space checks in CI templates into a centralized, parameterized approach
  • MSBuild cleanup: Removes unused properties from CompileAppManifest task
  • Deprecations: Marks GameKit default leaderboard methods and Security shared credential APIs as deprecated/obsoleted

Reviewed changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Make.config, Make.versions Update Xcode version to 26.2 and corresponding package URLs
tools/common/SdkVersions.cs Update SDK version constants to 26.2 for all platforms
builds/Versions-*.plist.in Add 26.2 to supported SDK version lists
tools/devops/automation/templates/common/setup.yml Centralize disk space check with parameterized values
tools/devops/automation/templates/tests/build.yml Remove inline disk check, use centralized template
tools/devops/automation/templates/mac/build.yml Remove inline disk check
src/authenticationservices.cs Add new password generation and save request APIs
src/avfoundation.cs Add edge light and far-field input APIs
src/healthkit.cs Add hypertension event category type identifier
src/gamekit.cs Deprecate default leaderboard methods, add arcade trigger
src/gamecontroller.cs Add physical input extents protocol
src/browserenginekit.cs Add web content filter APIs
src/safariservices.cs Add extension manager and state APIs
src/passkit.cs Add Conecs payment network and usage description key
src/webkit.cs Disable default constructor for WKFrameInfo
src/Foundation/NSNumber2.cs Enable nullable reference types with null checks and documentation
src/Foundation/NSNotificationCenter.cs Enable nullable reference types with improved documentation
src/Foundation/NSNetService.cs Enable nullable reference types
src/Foundation/NSMutableOrderedSet_1.cs Enable nullable reference types, add operator documentation and attributes
src/Security/SecSharedCredential.cs Mark SecAddSharedWebCredential as obsoleted in 26.2
src/SafariServices/SSEnums.cs Add MaximumAttemptsExceeded error code
src/AVFoundation/Enums.cs Add FarFieldInput audio session category option
msbuild/Xamarin.MacDev.Tasks/Tasks/CompileAppManifest.cs Remove unused AssemblyName, Debug, IsWatchApp, IsWatchExtension, IsXPCService properties
msbuild/Xamarin.Shared/Xamarin.Shared.targets Remove unused parameter passing
tests/monotouch-test/Foundation/NSMutableOrderedSet1Test.cs Add comprehensive tests for operators with null handling
tests/monotouch-test/HealthKit/CategoryTypeIdentifierTest.cs Add test for HypertensionEvent
tests/introspection/iOSApiProtocolTest.cs Skip SFSafariExtensionState conformance checks
tests/common/TestRuntime.cs Add version checking for Xcode 26.1 and 26.2
tests/xtro-sharpie/api-annotations-dotnet/*.todo Track new unbound APIs
tests/xtro-sharpie/api-annotations-dotnet/*.ignore Ignore expected platform differences
tests/cecil-tests/Documentation.KnownFailures.txt Update known documentation failures
tests/msbuild/Xamarin.MacDev.Tasks.Tests/* Remove AssemblyName from test task setup
runtime/xamarin/launch.h Remove obsolete header file
eng/Version.Details.props Update xharness version dependency

@rolfbjarne rolfbjarne enabled auto-merge December 15, 2025 08:56
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

This will eventually become 27.0, when .NET 11 goes stable (for now there's no Xcode 26.0/1 support in .NET 11, only Xcode 26.2).
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #b6281b3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #b6281b3] Build passed (Build packages) ✅

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #b6281b3] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #b6281b3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #b6281b3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #b6281b3] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #b6281b3] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 7 tests failed, 119 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

Failed tests

  • DotNet tests: Failed (Execution failed with exit code 1)
    • Xamarin.Tests.AppSizeTest.CoreCLR_Interpreter(iOS,"ios-arm64"): Multiple failures or warnings in test:
  1. App size changed significantly (+38,581 bytes (37.7 KB = 0.0 MB) different > toleran...

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

2 tests failed, 9 tests passed.

Failed tests

  • monotouch-test/iOS - simulator/Debug (CoreCLR): Crashed
  • monotouch-test/iOS - simulator/Release (CoreCLR): Crashed

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

2 tests failed, 11 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug (CoreCLR): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (CoreCLR): Failed (Test run crashed (exit code: 139).
    Test run crashed)

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

2 tests failed, 9 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug (CoreCLR): Failed
  • monotouch-test/tvOS - simulator/Release (CoreCLR): Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 7 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: b6281b394dfdd0d287b9f10bbdc59bf6b9fb16ff [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants