Skip to content

[net11.0] [dotnet] Fix computing _LibMonoLinkMode when not using Mono. #24488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
Jan 9, 2026
Merged

[net11.0] [dotnet] Fix computing _LibMonoLinkMode when not using Mono. #24488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,12 +1211,13 @@
<_IsDedupEnabled Condition="'$(_IsDedupEnabled)' == '' And '$(_RunAotCompiler)' == 'true' And '$(IsMacEnabled)' == 'true' And '$(TargetArchitectures)' == 'ARM64' And '$(MtouchInterpreter)' != 'all'">true</_IsDedupEnabled>
<_DedupAssembly Condition="'$(_IsDedupEnabled)' == 'true'">$(IntermediateOutputPath)aot-instances.dll</_DedupAssembly>

<!-- This property isn't accurate with CoreCLR, it should probably be renamed to something like '_LibRuntimeLinkMode' at some point -->
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(UseMonoRuntime)' == 'false'">dylib</_LibMonoLinkMode>
<!-- default to 'static' for Mac Catalyst to work around https://github.com/dotnet/macios/issues/14686 -->
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(_PlatformName)' == 'MacCatalyst'">static</_LibMonoLinkMode>
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(ComputedPlatform)' != 'iPhone'">dylib</_LibMonoLinkMode>
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == ''">static</_LibMonoLinkMode>
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(_PlatformName)' == 'MacCatalyst' And '$(UseMonoRuntime)' == 'true'">static</_LibMonoLinkMode>
<!-- temporarily use 'dylib' for CoreCLR on mobile because we need to implement .dylib -> .framework conversion to use 'static' -->
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And ('$(_PlatformName)' == 'iOS' Or '$(_PlatformName)' == 'tvOS') And '$(_XamarinRuntime)' == 'CoreCLR'">dylib</_LibMonoLinkMode>
<!-- we can't use dylibs for mobile apps when building for device, because the App Store won't allow it -->
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == '' And '$(ComputedPlatform)' == 'iPhone'">static</_LibMonoLinkMode>
<_LibMonoLinkMode Condition="'$(_LibMonoLinkMode)' == ''">dylib</_LibMonoLinkMode>
<_LibMonoExtension Condition="'$(_LibMonoLinkMode)' == 'dylib'">dylib</_LibMonoExtension>
<_LibMonoExtension Condition="'$(_LibMonoLinkMode)' == 'static'">a</_LibMonoExtension>

Expand Down
13 changes: 4 additions & 9 deletions tests/dotnet/UnitTests/expected/iOS-NativeAOT-size.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
AppBundleSize: 3,827,118 bytes (3,737.4 KB = 3.6 MB)
AppBundleSize: 2,483,703 bytes (2,425.5 KB = 2.4 MB)
# The following list of files and their sizes is just informational / for review, and isn't used in the test:
_CodeSignature/CodeResources: 3,879 bytes (3.8 KB = 0.0 MB)
_CodeSignature/CodeResources: 2,589 bytes (2.5 KB = 0.0 MB)
archived-expanded-entitlements.xcent: 384 bytes (0.4 KB = 0.0 MB)
Info.plist: 1,167 bytes (1.1 KB = 0.0 MB)
libSystem.Globalization.Native.dylib: 94,032 bytes (91.8 KB = 0.1 MB)
libSystem.IO.Compression.Native.dylib: 875,296 bytes (854.8 KB = 0.8 MB)
libSystem.Native.dylib: 147,168 bytes (143.7 KB = 0.1 MB)
libSystem.Net.Security.Native.dylib: 71,824 bytes (70.1 KB = 0.1 MB)
libSystem.Security.Cryptography.Native.Apple.dylib: 201,856 bytes (197.1 KB = 0.2 MB)
Info.plist: 1,138 bytes (1.1 KB = 0.0 MB)
PkgInfo: 8 bytes (0.0 KB = 0.0 MB)
runtimeconfig.bin: 1,808 bytes (1.8 KB = 0.0 MB)
SizeTestApp: 2,429,696 bytes (2,372.8 KB = 2.3 MB)
SizeTestApp: 2,477,776 bytes (2,419.7 KB = 2.4 MB)
Loading