-
Notifications
You must be signed in to change notification settings - Fork 554
Enable partial Linux builds for Copilot support #24494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
20
commits into
main
Choose a base branch
from
copilot/make-repository-build-linux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
418acdd
Initial plan
Copilot d08f626
Add Linux build support - fix system checks and Makefile issues
Copilot 7d7ff7c
Fix sed and cache directory issues for Linux builds
Copilot 7fcbf2e
Address PR feedback: remove ProjectInspector.csproj files, use 'place…
Copilot c5ff867
Skip runtime directory on Linux to avoid native compilation
Copilot e807828
Add GitHub Actions workflow to verify Linux builds
Copilot 9863bda
Remove accidentally added build artifact file
Copilot e348f28
Simplify Linux build workflow based on PR feedback
Copilot a21bcfb
Fix Linux build issues: XCODE_VERSION/URL unconditioned, fix DotNetGl…
Copilot a717133
Fix sed syntax for Linux in create-makefile-fragment.sh
Copilot b321c1f
Fix case-sensitivity: rename quicklookUI.cs to quicklookui.cs
Copilot aa692f5
Fix case-sensitivity: rename ILLink.Substitutions files to match plat…
Copilot 3245a76
Skip AppleDocReader (macOS-only tool) on Linux for documentation gene…
Copilot 5696bcd
Merge branch 'main' into copilot/make-repository-build-linux
rolfbjarne 17478cd
Skip Windows package builds on Linux
Copilot 8e7d97a
Skip xmllint XML validation on Linux (xmllint not available)
Copilot 1456993
Skip native registrar builds in mmp/mtouch on Linux (require Xcode)
Copilot 15c2f11
Fix git blame caret issue in create-make-config.sh for Linux builds
Copilot 20e527b
Use parallel make in Linux build workflow for improved build speed
Copilot 47a15c4
Merge main and add ProjectInspector.csproj to .gitignore
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # yamllint disable rule:line-length rule:document-start rule:truthy | ||
| name: Linux Build Verification | ||
| on: | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| linux-build: | ||
| name: Verify Linux Build | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: 'Checkout' | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| submodules: recursive | ||
|
|
||
| - name: Check system dependencies | ||
| run: | | ||
| set -ex | ||
| ./system-dependencies.sh | ||
|
|
||
| - name: Build on Linux | ||
| run: | | ||
| set -ex | ||
| make -j$(nproc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [submodule "external/Xamarin.MacDev"] | ||
| path = external/Xamarin.MacDev | ||
| url = ../../dotnet/macios-devtools | ||
| url = https://github.com/dotnet/macios-devtools | ||
| branch = main | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Target | ||
| Name="_PrepareRunDesktop" | ||
| BeforeTargets="ComputeRunArguments" | ||
| Condition="'$(_PlatformName)' == 'macOS' Or '$(_PlatformName)' == 'MacCatalyst'"> | ||
|
|
||
| <PropertyGroup Condition="'$(RunWithOpen)' != 'false'"> | ||
| <_OpenArguments Condition="'$(XamarinDebugMode)' != ''">$(_OpenArguments) --env __XAMARIN_DEBUG_MODE__=$(XamarinDebugMode)</_OpenArguments> | ||
| <_OpenArguments Condition="'$(XamarinDebugPort)' != ''">$(_OpenArguments) --env __XAMARIN_DEBUG_PORT__=$(XamarinDebugPort)</_OpenArguments> | ||
| <_OpenArguments Condition="'$(XamarinDebugHosts)' != ''">$(_OpenArguments) --env "__XAMARIN_DEBUG_HOSTS__=$(XamarinDebugHosts)"</_OpenArguments> | ||
| <_OpenArguments Condition="'$(XamarinDebugConnectTimeout)' != ''">$(_OpenArguments) --env __XAMARIN_DEBUG_CONNECT_TIMEOUT__=$(XamarinDebugConnectTimeout)</_OpenArguments> | ||
| <_OpenArguments Condition="'$(StandardOutputPath)' != ''">$(_OpenArguments) --stdout "$(StandardOutputPath)"</_OpenArguments> | ||
| <_OpenArguments Condition="'$(StandardErrorPath)' != ''">$(_OpenArguments) --stderr "$(StandardErrorPath)"</_OpenArguments> | ||
| <_OpenArguments Condition="'$(StandardInputPath)' != ''">$(_OpenArguments) --stdin "$(StandardInputPath)"</_OpenArguments> | ||
| <_OpenArgumentsPre Condition="'$(OpenNewInstance)' == 'true'">-n </_OpenArgumentsPre> | ||
| <_OpenArgumentsPre Condition="'$(OpenWaitForExit)' == 'true'">$(_OpenArgumentsPre) -W </_OpenArgumentsPre> | ||
| <_OpenArguments>$(_OpenArguments) $(RunEnvironment)</_OpenArguments> | ||
| <RunCommand>open</RunCommand> | ||
| <RunArguments>$(_OpenArgumentsPre) -a "$(TargetDir)/$(_AppBundleName).app" $(OpenArguments) $(_OpenArguments) --args</RunArguments> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(RunWithOpen)' == 'false'"> | ||
| <RunCommand>$(TargetDir)/$(_AppBundleName).app/Contents/MacOS/$(_NativeExecutableName)</RunCommand> | ||
| <RunArguments /> | ||
| </PropertyGroup> | ||
| </Target> | ||
| </Project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the XCODE_VERSION and XCODE_URL variables don't need to be conditioned on Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit a21bcfb.
XCODE_VERSIONandXCODE_URLare now set unconditionally (outside theifndef IS_LINUXblock).