Conversation
No api changes
- Update the XCODE_IS_STABLE detection to classify app names with “-rc”/“-beta” suffixes as preview builds. - Keep XCODE_CHANNEL=Beta for RC builds so the pipeline targets beta agents. - Fixes the “Validate Xcode channel” failure for Xcode 26.3 RC by preventing misclassification as stable.
Update Xcode stability detection so RC/beta app names are treated as preview builds. This reorders the name matching in Make.config and aligns system-dependencies.sh with the same rule, preventing beta-channel builds from being rejected as stable.
Adjust validate-xcode-channel.sh to re-derive preview/stable from the Xcode app name.\n\nThis ensures RC/beta app bundles are treated as preview even if Make.config reports stable, avoiding Beta-channel build failures.
|
heh I don't think that is the right fix copilot :P |
|
In any case @rolfbjarne I was wondering, should we just leave and treat RC releases just as Stable releases? I am somewhat inclined to do that but want you opinion before going there. Usually RC releases are final but we have seen cases where they ship RC2s |
PR #24494 introduced linux support and XCODE_CHANNEL logic is harcoded to stable always so fix it
nevermind I just answered myself heh, the answer is definitely no
|
✅ [CI Build #7a826e9] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #7a826e9] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ [PR Build #7a826e9] Build passed (Detect API changes) ✅Pipeline on Agent |
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
💻 [CI Build #7a826e9] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #7a826e9] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #7a826e9] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #7a826e9] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #7a826e9] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #7a826e9] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 114 tests passed. Failures❌ windows tests [attempt 3]Details# 🎉 All 3 tests passed 🎉Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |

No api changes