[tests] Misc CodeQL fixes/ignores. - #26506
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates a few test-only HTTP/TLS helpers to address CodeQL findings by tightening listener bindings and adding targeted CodeQL suppression justifications in test code.
Changes:
- Restrict the xharness Jenkins
HttpListenerprefix away fromhttp://*toward loopback-only. - Add CodeQL suppression comments for test-server response stream writes / file serving.
- Add a CodeQL suppression comment for a test that intentionally sets TLS 1.0.
File summaries
| File | Description |
|---|---|
| tests/xharness/Jenkins/TestServer.cs | Restricts test server binding scope and adds CodeQL suppression comments around file serving/response writes. |
| tests/monotouch-test/System.Net.Http/HttpbinTestServer.cs | Adds CodeQL suppression comment for writing exception bodies to the response stream in a localhost-only test server. |
| tests/linker/link sdk/CryptoTest.cs | Adds CodeQL suppression comment for intentionally enabling TLS 1.0 in a linker regression test. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #01ae20f] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 205 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Backport of #26506. --------- Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
No description provided.