[Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage #28844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
reviewed
Apr 8, 2025
| @@ -635,22 +635,27 @@ protected virtual ColorStateList GetItemTextColorStates() | |||
| } | |||
| else | |||
| { | |||
| // UnSelected tabs TextColor | |||
| if (barItemColor is not null) | |||
There was a problem hiding this comment.
Here we repeat some code and can just create a new method:
int GetItemTextColor(Color? customColor, OriginalTabTextColors? originalColors)
{
return customColor?.ToPlatform().ToArgb() ?? originalColors?.DefaultColor ?? 0;
}
To get a cleaner version:
// UnSelected tabs TextColor
defaultColor = GetItemTextColor(barItemColor, _originalTabTextColors);
// Selected tabs TextColor
checkedColor = GetItemTextColor(barSelectedItemColor, _originalTabTextColors);
There was a problem hiding this comment.
Thanks for the feedback. I have optimized the code as suggested @jsuarezruiz
| public void DefaultSelectedTabTextColorShouldApplyProperly() | ||
| { | ||
| App.WaitForElement("Tab1"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots in Android, Mac and Windows. Trigger a build.
There was a problem hiding this comment.
I have added the pending snapshots.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Apr 10, 2025
PureWeen
pushed a commit
that referenced
this pull request
Apr 16, 2025
…abbedPage (#28844) * Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage on Android * Added pending snap and optimized the fix
sheiksyedm
pushed a commit
to sheiksyedm/maui
that referenced
this pull request
Apr 17, 2025
…abbedPage (dotnet#28844) * Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage on Android * Added pending snap and optimized the fix
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 17, 2025
…abbedPage (dotnet#28844) * Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage on Android * Added pending snap and optimized the fix
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
…abbedPage (#28844) * Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage on Android * Added pending snap and optimized the fix
PureWeen
added a commit
that referenced
this pull request
Apr 23, 2025
### Description of Change ## .NET MAUI Release Notes - Inflight/Candidate ## What's Changed ### MAUI Product Fixes * Fix CarouselView layout SR6 regressions by @albyrock87 in #29035 * Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen in https://github.com/dotnet/maui/pull/1fb5164929 * [Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in #28996 * [Android] picker - focus/unfocus events by @kubaflo in #28122 * [XC] add IRootObjectProvider by @StephaneDelcroix in #28310 * [iOS] Fix for the File.ContentType from MediaPicker not being in valid MIME format by @SyedAbdulAzeemSF4852 in #28842 * [Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage by @Ahamed-Ali in #28844 * [iOS] Fix FlyoutPage does not respond to changes in the FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in #28884 * [Android] Fixed ScalingCanvas.SetBlur not working by @NirmalKumarYuvaraj in #28911 * [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in CV2 by @prakashKannanSf3972 in #28641 * [iOS] Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in #28890 * [Windows] - Fix Visual State Issue with Picker TextColor After Navigation by @prakashKannanSf3972 in #28746 ### Dependency Updates * [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in #28499 ### Testing * [Testing] Feature Matrix UITest Cases for CollectionView EmptyView Feature by @NafeelaNazhir in #28679 * Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by @HarishKumarSF4517 in #29049 **Full Changelog**: main...inflight/candidate For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
UnselectedTabColoron a TabbedPage, the selected tab's text color incorrectly adopts the unselected tab color on Android.Root Cause of the issue
Description of Change
Issues Fixed
Fixes #28838
Tested the behaviour in the following platforms
Screenshot