-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage #28844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+17.6 KB
...roid.Tests/snapshots/android/DefaultSelectedTabTextColorShouldApplyProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
namespace Maui.Controls.Sample.Issues; | ||
[Issue(IssueTracker.Github, 28838, "Incorrect Text Color Applied to Selected Tab in TabbedPage on Android", PlatformAffected.Android)] | ||
public class Issue28838 : TabbedPage | ||
{ | ||
public Issue28838() | ||
{ | ||
// Set the UnselectedTabColor property , it should be applied only to the unselected tab. | ||
UnselectedTabColor = Colors.Red; | ||
|
||
// Add tabs (pages) | ||
Children.Add(new Issue28838Tab1()); | ||
Children.Add(new Issue28838Tab2()); | ||
Children.Add(new Issue28838Tab3()); | ||
} | ||
} | ||
|
||
public class Issue28838Tab1 : ContentPage | ||
{ | ||
public Issue28838Tab1() | ||
{ | ||
Title = "Tab 1"; | ||
var verticalStackLayout = new VerticalStackLayout | ||
{ | ||
VerticalOptions = LayoutOptions.Center, | ||
Children = { | ||
new Label | ||
{ | ||
HorizontalOptions = LayoutOptions.Center, | ||
Text = "Tab 1", | ||
AutomationId = "Tab1" | ||
}, | ||
} | ||
}; | ||
Content = verticalStackLayout; | ||
} | ||
} | ||
|
||
public class Issue28838Tab2 : ContentPage | ||
{ | ||
public Issue28838Tab2() | ||
{ | ||
Title = "Tab 2"; | ||
var verticalStackLayout = new VerticalStackLayout | ||
{ | ||
VerticalOptions = LayoutOptions.Center, | ||
Children = { | ||
new Label | ||
{ | ||
HorizontalOptions = LayoutOptions.Center, | ||
Text = "Tab 2" | ||
} | ||
} | ||
}; | ||
Content = verticalStackLayout; | ||
} | ||
} | ||
public class Issue28838Tab3 : ContentPage | ||
{ | ||
public Issue28838Tab3() | ||
{ | ||
Title = "Tab 3"; | ||
var verticalStackLayout = new VerticalStackLayout | ||
{ | ||
VerticalOptions = LayoutOptions.Center, | ||
Children = { | ||
new Label | ||
{ | ||
HorizontalOptions = LayoutOptions.Center, | ||
Text = "Tab 3" | ||
} | ||
} | ||
}; | ||
Content = verticalStackLayout; | ||
} | ||
} |
Binary file added
BIN
+7.08 KB
...ases.Mac.Tests/snapshots/mac/DefaultSelectedTabTextColorShouldApplyProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions
19
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28838.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
public class Issue28838 : _IssuesUITest | ||
{ | ||
public Issue28838(TestDevice device) : base(device) { } | ||
|
||
public override string Issue => "Incorrect Text Color Applied to Selected Tab in TabbedPage on Android"; | ||
|
||
[Test] | ||
[Category(UITestCategories.TabbedPage)] | ||
public void DefaultSelectedTabTextColorShouldApplyProperly() | ||
{ | ||
App.WaitForElement("Tab1"); | ||
VerifyScreenshot(); | ||
} | ||
} |
Binary file added
BIN
+5.88 KB
...inUI.Tests/snapshots/windows/DefaultSelectedTabTextColorShouldApplyProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+53.2 KB
...ases.iOS.Tests/snapshots/ios/DefaultSelectedTabTextColorShouldApplyProperly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshots in Android, Mac and Windows. Trigger a build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the pending snapshots.