[Android] [iOS] [macOS] ContentView and ScrollView also need to handle InputTransparent#21025
Closed
mattleibow wants to merge 24 commits intomainfrom
Closed
[Android] [iOS] [macOS] ContentView and ScrollView also need to handle InputTransparent#21025mattleibow wants to merge 24 commits intomainfrom
mattleibow wants to merge 24 commits intomainfrom
Conversation
mattleibow
changed the title
mattleibow
commented
Mar 5, 2024
| { | ||
| layoutViewGroup.InputTransparent = layout.InputTransparent; | ||
| } | ||
| ViewHandler.MapInputTransparent(handler, layout); |
Member
Author
There was a problem hiding this comment.
This logic is no longer needed as we do it in the ViewHandler mapper.
src/Core/src/ViewExtensions.cs
Outdated
|
|
||
| #if ANDROID | ||
| if (view?.InputTransparent == true) | ||
| if (view?.InputTransparent == true && (platformView is null || platformView is not IInputTransparentManagingView)) |
Member
Author
There was a problem hiding this comment.
This line matches the change in the transparency logic - if we can handle it ourselves, we don't wrap.
Eilon
added
the
area-layout
Member
|
/rebase |
jsuarezruiz
reviewed
Apr 24, 2024
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
Seems that there are some related tests failing:
ScrollViewInputTransparencySimpleMatrix(True,False,False)
Expected string length 65 but was 62. Strings differ at index 55.
Expected: "...t: ScrollViewTransControlIsClickableIsNotPassThru (SUCCESS 1)"
But was: "...t: ScrollViewTransControlIsClickableIsNotPassThru (FAIL 1)"
# Conflicts: # src/Controls/samples/Controls.Sample.UITests/Test.cs
mattleibow
changed the title
Contributor
|
How long will this take to wait? |
|
Hello, what is the status of this pull request? It would help me and my app a lot, if this would work again, because it breaks some UIs, and I have not found a work around. |
github-project-automation
bot
moved this from Todo
to Changes Requested
in MAUI SDK Ongoing
Contributor
|
Moving it here: #33582 |
github-project-automation
bot
moved this from Changes Requested
to Done
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Content views also need to handle the input transparent logic separately - such as
ContentViewandScrollView.If the flow of input transparency is not specifically handled, the native views will be wrapped with a blanket interceptor. In most cases, this is fine - buttons, labels and images do not have content. However, things like layouts, content views and scroll views do have content that needs to respect the cascading input transparency.
Windows PR: #23526
Issues Fixed
Fixes #21002