-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fire UpdateValue after all propertychange events #23746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Jul 21, 2024
PureWeen
commented
Jul 21, 2024
Member
Author
|
/rebase |
b48a102 to
2d4dd6c
Compare
PureWeen
commented
Jul 25, 2024
| } | ||
|
|
||
| #if WINDOWS | ||
| private protected override void ProposeUpdateHandlerValue(string property, bool valueChanged) |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context
#23329
mattleibow
reviewed
Jul 25, 2024
mattleibow
reviewed
Jul 25, 2024
mattleibow
reviewed
Jul 25, 2024
mattleibow
reviewed
Jul 25, 2024
Member
mattleibow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good and I think this one was a long-standing issue/sadness.
mattleibow
previously approved these changes
Jul 25, 2024
StephaneDelcroix
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #5587