Skip to content

[PERFORMANCE][SECURITY] Refactored Regex to cached (static readonly, Compiled, source generated, with timeout for security) #26095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 67 commits into
base: main
Choose a base branch
from
Draft

[PERFORMANCE][SECURITY] Refactored Regex to cached (static readonly, Compiled, source generated, with timeout for security) #26095

wants to merge 67 commits into from

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Nov 25, 2024 •
edited
Loading

Refactored Regex for performance and security

Please ignore formatting for now.

Description of Change

  1. use of source generators for net7.0+ (performance)
  2. use of Compiled option for non net7.0+ (performance)
  3. added timeout for security reasons
  4. class and method local Regex objects refactored to cached (static readonly)

@moljac moljac requested review from a team as code owners November 25, 2024 12:29
@moljac moljac marked this pull request as draft November 25, 2024 12:29
@moljac moljac self-assigned this Nov 25, 2024
@moljac
Copy link
Contributor Author

moljac commented Nov 25, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac moljac changed the title [Performance][Security] Refactored Regex to cached (static readonly, Compiled, source generated, with timeout for security) [PERFORMANCE][SECURITY] Refactored Regex to cached (static readonly, Compiled, source generated, with timeout for security) Nov 25, 2024
@moljac
Copy link
Contributor Author

moljac commented Nov 25, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented Nov 25, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented Nov 26, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented Nov 27, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented Dec 3, 2024

/rebase

@moljac moljac force-pushed the dev/moljac/20241115-net9.0-performance-regex-source-generator branch from b93adac to 7bf09c5 Compare February 21, 2025 14:57
@moljac
Copy link
Contributor Author

moljac commented Feb 23, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@moljac
Copy link
Contributor Author

moljac commented May 15, 2025

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@moljac moljac

Labels
area-architecture Issues with code structure, SDK structure, implementation details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moljac @MartyIX @jfversluis