Fix for Try scrolling down and when new items are added the first item does not kept in the displayed list. #27153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
sheiksyedm
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 16, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Feb 4, 2025
| _itemsUpdateScrollObserver.Start(ItemsViewAdapter); | ||
| } | ||
| // We need to observe the adapter for changes for the ItemsUpdatingScrollMode. | ||
| _itemsUpdateScrollObserver.Start(ItemsViewAdapter); |
There was a problem hiding this comment.
These CollectionView tests are failing:
The App is crashing. Could you check if are related with the changes?
There was a problem hiding this comment.
These CollectionView tests are failing:
The App is crashing. Could you check if are related with the changes?
Hi @jsuarezruiz Yes, the crash is due to the DataObserver included for KeepItemsInView. I have modified ElementAt() and DetermineTargetPosition. Please review the changes and let us know if you have any concerns.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-26810
branch
from
5ddcf7b to
b8d8a6e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
When the
ItemsUpdatingScrollModeis set toKeepItemsInView,scrolling down in the list and adding a new item does not move the newly added item to the first position.Root Cause
Android: In the
MauiRecyclerView, the data change observer is paused forKeepItemsInViewinItemsUpdatingScrollModeto maintain the first position of the item.iOS and Mac: In the
ItemsViewLayout, the collection update does not account for theItemsUpdatingScrollModeset toKeepItemsInView, causing the current position to remain unchanged despite the scroll mode settings.Description of Change
Android: We need to observe the data changes for the
KeepItemsInViewoption, as there may be cases where the item might not remain in view.The issue is fixed by restarting the data change observer inMauiRecyclerView.iOS and Mac: The issue is addressed by updating the scroll behavior in the
ItemsLayoutfor iOS, including theForceScrollToFirstItemmethod to correctly adjust the scroll position.Issues Fixed
Fixes #26810
Tested the behaviour in the following platforms
Known Issue
ItemsUpdatingScrollModeis not implemented in CollectionView2Output Screenshot
BeforeFix.mov
AfterFix.mov