Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Fix flaky UITests failing sometimes 2 #27154

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jan 15, 2025

Description of Change

  • TestDoesntCrashWithCachingDisable (Failing because we removed the Legacy Gallery Remove Legacy Gallery from SLNs #26068 and the test was using images from that gallery).
  • CollectionViewHeaderTemplateAndFooterTemplateDontWork. Not passing (temporary).
  • HeaderFooterStringWorks. Not passing (temporary).

@jsuarezruiz jsuarezruiz changed the title [Testing] Fix flaky UITests failing sometimes 1 [Testing] Fix flaky UITests failing sometimes 2 Jan 15, 2025
presidents.Add(new President($"Presidente 37", 8, $"https://github.com/dotnet/maui/blob/main/src/Compatibility/ControlGallery/src/Android/Resources/drawable/xamarinstore.jpg?raw=true"));
presidents.Add(new President($"Presidente 36", 9, $"https://github.com/dotnet/maui/blob/main/src/Compatibility/ControlGallery/src/Android/Resources/drawable/oasis.jpg?raw=true"));
presidents.Add(new President($"Presidente 35", 10, $"https://github.com/dotnet/maui/blob/main/src/Compatibility/ControlGallery/src/Android/Resources/drawable/Vegetables.jpg?raw=true"));
presidents.Add(new President($"Presidente 44", 1, $"https://github.com/dotnet/maui/blob/main/src/Controls/tests/TestCases.HostApp/Resources/Images/avatar.png?raw=true"));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed the Legacy Gallery #26068 and the test was using images from that gallery. For that reason, was failing.

@jsuarezruiz jsuarezruiz added area-testing Unit tests, device tests testing-flakiness labels Jan 16, 2025
@@ -1859,7 +1859,7 @@ public static void TapBackArrow(this IApp app, string customBackButtonIdentifier
/// <param name="query">The custom IQuery for the back button.</param>
public static void TapBackArrow(this IApp app, IQuery query)
{
app.Tap(query);
app.WaitForElement(query).Tap();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait to find the Back Button before try to tap it.

@jsuarezruiz jsuarezruiz marked this pull request as ready for review January 17, 2025 12:25
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 17, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests testing-flakiness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant