[iOS] Make sure the Window is available#28013
Closed
tj-devel709 wants to merge 45 commits intomainfrom
Closed
Conversation
tj-devel709
added
platform/ios
area-controls-window
This reverts commit 47de72a.
… - 2 (#27405) * Migrated the ContextMenu related test cases * Addressed the feedback and added one more case * Removed snapshots and updated the some test cases * Added the comments
…ion - 9 (#27743) * Enabled TestCases in All platforms * Updated changes * Updated Snapshots * Updated Mac Snapshots * Update Issue25362.cs
…ion - 10 (#27751) * Migrated the 8 cases from issues folder * Addressed the feedbacks * Migrated the 8 cases from issues folder * Updated the snapshots for Mac platform * Updated the Issue20920 * Updated the Issue20920.cs * Added the images for mac platform * Addressed the feedbacks * Updated the Issue20920 * Issue5191 test enabled for the Mac platform * Migrated the 8 cases from issues folder * Migrated the 8 cases from issues folder * Updated the Issue20920 * Added the images for mac platform * Addressed the feedbacks * Updated the Issue22306
* Verified the flaky test cases * Verified the Flaky related test cases * Addressed the Feedbacks * Added the Issue20535 * Added the comment to the Issue2354 * Update the snapshot for Windows platform
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The `_PublishBlobItems` target in `eng/Publishing.props` needs to hook into the publishing targets, and it looks like `PublishDependsOnTargets` can be used to accomplish this.
…View (#27669) * Added repro sample * Added UITest * Some changes based on the issue attached log (cannot repro the issue)
* Fixed the IsEnabled property dynamic updating issue. * Updated the fix and added the test case. * Added the output images for android and iOS * Updated the fix and test case. * Added the output image. * Updated the test case and output image * Added color for check box * Updated windows image. * Added the macOS output image
* [ci] Remove usage on cake script * [ci] Restore packages with net10 by not using PackagePruning
…ion - 11 (#27764) * enable test case for all platforms * update the changes * modified changes * replace snapshot * update the changes * modified changes * modified
* [android] move `IsDispatchRequiredImplementation()` to Java Context: #8919 Context: https://github.com/jonathanpeppers/MAUI_CollectionView/tree/net9.0 Profiling the above sample, I saw a lot of time in: 46.21ms (0.89%) 0.00ns (<0.01%) Microsoft!Microsoft.Maui.Dispatching.Dispatcher.IsDispatchRequiredImplementation() `Microsoft.Maui.Dispatching.Dispatcher.IsDispatchRequired` looks like it is called *a lot* by .NET MAUI, so it's likely worth improving here. Almost all of the time is spent on the check: _looper != Looper.MyLooper(); `MyLooper()` does interop to Java, and then bookkeeping to create a C# instance of the `Looper`. You can see this time spent inside `IsDispatchRequiredImplementation()` as: 20.18ms (44%) Mono.Android!Java.Lang.Object.GetObject(intptr,Android.Runtime.JniHandleOwnership) If we instead move the call to Java, C# can instead call a new `PlatformDispatcher` type that extends `Handler`: _dispatcher.IsDispatchRequired; So now C# calls a Java method that simply returns a `bool`, and no C# `Looper` instance has to be created or managed. This completely removes the ~20ms or so we see spent in `Java.Lang.Object.GetObject()`. This will also help performance tiny amount at startup, as we don't call `MyLooper()` or `MainLooper` any longer in C#, when creating the `Dispatcher`. * Update src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformDispatcher.java
* [ci] Move device tests to Sequoia * [ci] Fix provisioning uitests * [ci] Move templates to Sequoia * [ci] Make sure to run iOS tests on 18.0 simulators
* remove Dispose call on ShellItemRenderer * update publicAPI txt
* Added UITest for SliderControl * Modified changes in UI * Modified UI Test cases * Added snapshots for Android * Updated the images for android * Added images for IOS * Addressed feedbacks * Added images for Catalyst and Windows * Added Markdown File --------- Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com>
* Fix naming * More changes * Updated test * Updated snapshot * More changes
…27610) * [BindingSG] Added Binding.Create support for xaml generated sources * Removed redundant checks from BindingCreate verification
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* add DebuggerTypeProxy for Shell * add DebuggerTypeProxy for ShellItem and BaseShellItem * add DebuggerTypeProxy for ShellSectionCollection * add DebuggerTypeProxy for ShellSection and Collection
* [ci] Always provisioning on devdiv * [ci] Don t provision tvOS * Provision uitests * [ci] Fix uitest steps provisioning
… when binding context values are changed (#27151) * Fixed FlyoutItem issue * Fixed Flyout Issues. * Added test case. * Added snapshot for WinUI and Mac * Revert changes
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Implement the option to change system theme on Appium * Fix build error
* [Android] Fixed the ScrollbarVisibility issues * Committed the review changes and added additional test * Renamed Variable
…en dynamically updated. (#27742) * Fixed The FontImageSource icon color does not change in the TabbedPage when dynamically updated. * Updated code changes
* Update SkiaSharp package versions * Update GTK to match the new versions * Use the new SkiaSharp APIs in resizetizer * Regenerate resizetizer test images * Improve test assertions * Color ToString is invariant * Update Graphics.Skia with new SkiaSharp APIs * Regenerate graphics images * Force all images to be regenerated on CI * Fix stack overflow by setting the typeface
* Fixed-ImageButton-Padding-Issue-iOS * Modified-code * Optimized-code * Added-Mac-Snapshot * fixed-conflicts * Removed-nullable-directive * Resolved-Conflicts * Modified-Code * Updated-Snapshots * Modified-Code * Modified-Snapshot --------- Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
…15668) * IsNullOrEmpty for Paint not returning true if Colors are not set * Updated unit test * Updated tests * More tests * Added more tests * Updated conditions * Added more tests * Changed condition to work when only one collor is missing --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
There is an issue where the KeyboardAutoManagerScroll.AnimateHidingKeyboard is looking for the NextResponder after the Window has been garbage collected. These changes will make sure if the Window has been GC'd, we will stop the search and return null.
This PR still needs to be tested
Issues Fixed
Fixes #dotnet/macios#21648