Update CommunityToolkit.Maui reference in sample content template by jfversluis · Pull Request #28510 · dotnet/maui

jfversluis · 2025-03-19T15:19:58Z

Description of Change

Updates the CommunityToolkit.Maui reference in the new project template to the latest versions.

Note that depending on targeting .NET 8 or 9 there will be a different version of CommunityToolkit.Maui referenced in the project file and 2 lines in the ManageMetaPage.xaml because of a breaking change between Toolkit versions.

As of version 10 of the Toolkit .NET 8 is no longer supported. So for .NET 8 we include the latest version of the Toolkit that works with .NET 8 (which is 9.1.1), when targeting .NET 9 we include the 11.1.1 version, which is the version that works with .NET MAUI 9.0.40. As of 11.2.0 .NET MAUI 9.0.50 is required and this change is meant to be inserted into Visual Studio with 9.0.40.

Also see: CommunityToolkit/Maui#2613

Copilot

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

src/Templates/src/templates/maui-mobile/MauiApp.1.csproj: Language not supported

jfversluis · 2025-03-19T16:10:16Z

Need to do more in-depth testing first with the changes in context binding inheritance and see if everything still works

dartasen · 2025-03-19T16:38:25Z

@jfversluis Latest community toolkit version isn't working with 9.0.50, it ends up in crash

jfversluis · 2025-03-20T21:49:47Z

For 9.0.50 not working I think we have #28456 or stick with 9.0.40 for now!

Changes addressed

PureWeen · 2025-04-04T17:50:17Z

/backport to release/9.0.1xx-sr4

PureWeen · 2025-04-04T17:50:22Z

/backport to release/9.0.1xx-sr5

github-actions · 2025-04-04T17:50:29Z

Started backporting to release/9.0.1xx-sr4: https://github.com/dotnet/maui/actions/runs/14271208626

github-actions · 2025-04-04T17:50:36Z

Started backporting to release/9.0.1xx-sr5: https://github.com/dotnet/maui/actions/runs/14271209988

…r/Footer After Changing ItemsLayout in CV2 (#28890) * [Testing] Fix for flaky UITests in CI that occasionally fail - 7 (#28764) * improve stability to flaky tests * Updated changes * Update CarouselViewUITests.LoopNoFreeze.cs * Update EntryClearButtonColorShouldMatchTextColor.png * Update CommunityToolkit.Maui reference in sample content template (#28510) * Update CommunityToolkit.Maui & Mvvm reference in template * Fix MAUI Toolkit breaking changes * Debump MVVM Toolkit * Update MauiApp.1.csproj * Update package version in MauiApp.1.csproj * Add framework-specific validation flags and update package version * Swap TextValidationBehavior Flags for frameworks * [Testing] Fix for flaky UITests in CI that occasionally fail - 6 (#28747) * Fixed flaky tests related to entry control * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed 19500 test * reverted the common changes * Fix typo in Issue19500.cs comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20250403.2 (#28819) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25167.9 -> To Version 9.0.0-prerelease.25203.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Issue19509.cs (#28807) * Resave mac tabbedpage images (#28803) * Fixed ListView leak caused by not disposed ContextActionsCell (#28702) * Fixed something that looks like copy/paste error * Fixed memory leak caused by not disposed ContextActionsCell * [Testing] Fix for flaky UITests in CI that occasionally fail - 8 (#28828) * improve stability to flaky test * Update Issue7678.cs * Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 * Included the test case and sample for the fix * Added the test case for footer --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vitaly Knyazev <VitalyKnyazev@users.noreply.github.com>

…r/Footer After Changing ItemsLayout in CV2 (dotnet#28890) * [Testing] Fix for flaky UITests in CI that occasionally fail - 7 (dotnet#28764) * improve stability to flaky tests * Updated changes * Update CarouselViewUITests.LoopNoFreeze.cs * Update EntryClearButtonColorShouldMatchTextColor.png * Update CommunityToolkit.Maui reference in sample content template (dotnet#28510) * Update CommunityToolkit.Maui & Mvvm reference in template * Fix MAUI Toolkit breaking changes * Debump MVVM Toolkit * Update MauiApp.1.csproj * Update package version in MauiApp.1.csproj * Add framework-specific validation flags and update package version * Swap TextValidationBehavior Flags for frameworks * [Testing] Fix for flaky UITests in CI that occasionally fail - 6 (dotnet#28747) * Fixed flaky tests related to entry control * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed 19500 test * reverted the common changes * Fix typo in Issue19500.cs comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20250403.2 (dotnet#28819) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25167.9 -> To Version 9.0.0-prerelease.25203.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Issue19509.cs (dotnet#28807) * Resave mac tabbedpage images (dotnet#28803) * Fixed ListView leak caused by not disposed ContextActionsCell (dotnet#28702) * Fixed something that looks like copy/paste error * Fixed memory leak caused by not disposed ContextActionsCell * [Testing] Fix for flaky UITests in CI that occasionally fail - 8 (dotnet#28828) * improve stability to flaky test * Update Issue7678.cs * Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 * Included the test case and sample for the fix * Added the test case for footer --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vitaly Knyazev <VitalyKnyazev@users.noreply.github.com>

…r/Footer After Changing ItemsLayout in CV2 (#28890) * [Testing] Fix for flaky UITests in CI that occasionally fail - 7 (#28764) * improve stability to flaky tests * Updated changes * Update CarouselViewUITests.LoopNoFreeze.cs * Update EntryClearButtonColorShouldMatchTextColor.png * Update CommunityToolkit.Maui reference in sample content template (#28510) * Update CommunityToolkit.Maui & Mvvm reference in template * Fix MAUI Toolkit breaking changes * Debump MVVM Toolkit * Update MauiApp.1.csproj * Update package version in MauiApp.1.csproj * Add framework-specific validation flags and update package version * Swap TextValidationBehavior Flags for frameworks * [Testing] Fix for flaky UITests in CI that occasionally fail - 6 (#28747) * Fixed flaky tests related to entry control * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed 19500 test * reverted the common changes * Fix typo in Issue19500.cs comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20250403.2 (#28819) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25167.9 -> To Version 9.0.0-prerelease.25203.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Issue19509.cs (#28807) * Resave mac tabbedpage images (#28803) * Fixed ListView leak caused by not disposed ContextActionsCell (#28702) * Fixed something that looks like copy/paste error * Fixed memory leak caused by not disposed ContextActionsCell * [Testing] Fix for flaky UITests in CI that occasionally fail - 8 (#28828) * improve stability to flaky test * Update Issue7678.cs * Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 * Included the test case and sample for the fix * Added the test case for footer --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vitaly Knyazev <VitalyKnyazev@users.noreply.github.com>

…r/Footer After Changing ItemsLayout in CV2 (dotnet#28890) * [Testing] Fix for flaky UITests in CI that occasionally fail - 7 (dotnet#28764) * improve stability to flaky tests * Updated changes * Update CarouselViewUITests.LoopNoFreeze.cs * Update EntryClearButtonColorShouldMatchTextColor.png * Update CommunityToolkit.Maui reference in sample content template (dotnet#28510) * Update CommunityToolkit.Maui & Mvvm reference in template * Fix MAUI Toolkit breaking changes * Debump MVVM Toolkit * Update MauiApp.1.csproj * Update package version in MauiApp.1.csproj * Add framework-specific validation flags and update package version * Swap TextValidationBehavior Flags for frameworks * [Testing] Fix for flaky UITests in CI that occasionally fail - 6 (dotnet#28747) * Fixed flaky tests related to entry control * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed 19500 test * reverted the common changes * Fix typo in Issue19500.cs comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20250403.2 (dotnet#28819) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25167.9 -> To Version 9.0.0-prerelease.25203.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Issue19509.cs (dotnet#28807) * Resave mac tabbedpage images (dotnet#28803) * Fixed ListView leak caused by not disposed ContextActionsCell (dotnet#28702) * Fixed something that looks like copy/paste error * Fixed memory leak caused by not disposed ContextActionsCell * [Testing] Fix for flaky UITests in CI that occasionally fail - 8 (dotnet#28828) * improve stability to flaky test * Update Issue7678.cs * Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 * Included the test case and sample for the fix * Added the test case for footer --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vitaly Knyazev <VitalyKnyazev@users.noreply.github.com>

…r/Footer After Changing ItemsLayout in CV2 (#28890) * [Testing] Fix for flaky UITests in CI that occasionally fail - 7 (#28764) * improve stability to flaky tests * Updated changes * Update CarouselViewUITests.LoopNoFreeze.cs * Update EntryClearButtonColorShouldMatchTextColor.png * Update CommunityToolkit.Maui reference in sample content template (#28510) * Update CommunityToolkit.Maui & Mvvm reference in template * Fix MAUI Toolkit breaking changes * Debump MVVM Toolkit * Update MauiApp.1.csproj * Update package version in MauiApp.1.csproj * Add framework-specific validation flags and update package version * Swap TextValidationBehavior Flags for frameworks * [Testing] Fix for flaky UITests in CI that occasionally fail - 6 (#28747) * Fixed flaky tests related to entry control * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25473.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixed 19500 test * reverted the common changes * Fix typo in Issue19500.cs comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> * Update dependencies from https://github.com/dotnet/xharness build 20250403.2 (#28819) Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 9.0.0-prerelease.25167.9 -> To Version 9.0.0-prerelease.25203.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update Issue19509.cs (#28807) * Resave mac tabbedpage images (#28803) * Fixed ListView leak caused by not disposed ContextActionsCell (#28702) * Fixed something that looks like copy/paste error * Fixed memory leak caused by not disposed ContextActionsCell * [Testing] Fix for flaky UITests in CI that occasionally fail - 8 (#28828) * improve stability to flaky test * Update Issue7678.cs * Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 * Included the test case and sample for the fix * Added the test case for footer --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vitaly Knyazev <VitalyKnyazev@users.noreply.github.com>

jfversluis added the area-templates Project templates, Item Templates for Blazor and MAUI label Mar 19, 2025

jfversluis added this to the .NET 9 SR6 milestone Mar 19, 2025

Copilot AI review requested due to automatic review settings March 19, 2025 15:19

jfversluis requested a review from a team as a code owner March 19, 2025 15:19

jfversluis requested review from StephaneDelcroix and tj-devel709 March 19, 2025 15:20

Copilot AI reviewed Mar 19, 2025

View reviewed changes

jfversluis marked this pull request as draft March 19, 2025 15:24

jfversluis marked this pull request as ready for review March 20, 2025 21:48

This comment was marked as outdated.

Sign in to view

This was referenced Mar 21, 2025

[release/9.0.1xx-sr4] Update CommunityToolkit.Maui & Mvvm reference in template #28553

Closed

[release/9.0.1xx-sr5] Update CommunityToolkit.Maui & Mvvm reference in template #28554

Closed

jfversluis mentioned this pull request Mar 21, 2025

Update DeveloperBalance with template updates dotnet/maui-samples#599

Merged

PureWeen added this to MAUI SDK Ongoing Mar 26, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Mar 26, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 26, 2025

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Mar 26, 2025

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

github-actions bot force-pushed the jfversluis-patch-3 branch from 4db0798 to 733c858 Compare March 27, 2025 14:36

This comment was marked as off-topic.

Sign in to view

github-actions bot force-pushed the jfversluis-patch-3 branch from 733c858 to d1dda39 Compare March 27, 2025 21:49

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Mar 28, 2025

jfversluis added 3 commits March 28, 2025 15:31

Update MauiApp.1.csproj

85f221f

Update package version in MauiApp.1.csproj

f866c3f

Add framework-specific validation flags and update package version

14e9581

jfversluis mentioned this pull request Apr 4, 2025

Remove .NET 8 specific code from sample content template #28800

Closed

jfversluis changed the title ~~Update CommunityToolkit.Maui & Mvvm reference in template~~ Update CommunityToolkit.Maui reference in sample content template Apr 4, 2025

jfversluis moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Apr 4, 2025

Swap TextValidationBehavior Flags for frameworks

f2c1205

PureWeen approved these changes Apr 4, 2025

View reviewed changes

PureWeen merged commit 97d5452 into main Apr 4, 2025
19 checks passed

PureWeen deleted the jfversluis-patch-3 branch April 4, 2025 14:25

github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Apr 4, 2025

jfversluis mentioned this pull request Apr 4, 2025

Bump CommunityToolkit/SF on IncludeSampleContent template #28324

Closed

github-actions bot locked and limited conversation to collaborators May 5, 2025

Conversation

jfversluis commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jfversluis commented Mar 19, 2025

Uh oh!

dartasen commented Mar 19, 2025

Uh oh!

jfversluis commented Mar 20, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as outdated.

Uh oh!

Uh oh!

PureWeen commented Apr 4, 2025

Uh oh!

PureWeen commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jfversluis commented Mar 19, 2025 •

edited

Loading