Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Binding for ListView.IsRefreshing #28516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Binding for ListView.IsRefreshing #28516

wants to merge 2 commits into from
+48 −2

Conversation

bill2004158
Copy link
Contributor

Description of Change

Set IsRefreshingProperty with SetterSpecificity.FromHandler,
to avoid break Binding.

Issues Fixed

Fixes #28514

@bill2004158
Update ListView.cs
3a02760 
Set IsRefreshingProperty with SetterSpecificity.FromHandler.
@bill2004158 bill2004158 requested a review from a team as a code owner March 19, 2025 16:38
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 19, 2025
mattleibow
mattleibow requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Are you able to write a unit test demonstrating the fix? I think somewhere in this file: https://github.com/dotnet/maui/blob/main/src/Controls/tests/Core.UnitTests/ListViewTests.cs

@mattleibow mattleibow added the area-controls-listview ListView and TableView label Mar 19, 2025
@bill2004158
Copy link
Contributor Author

@mattleibow ,
Ok, added the UnitTest.

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow requested changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area-controls-listview ListView and TableView community ✨ Community Contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bind ListView.IsRefreshing is not work.
3 participants
@bill2004158 @jsuarezruiz @mattleibow