[Windows] Fixed the issue with SearchBar focus and unfocus events.

[Ahamed-Ali]

Root Cause of the issue

• In ViewHandler.Windows, FocusManager.GotFocus and LostFocus are handled for other controls. However, for AutoSuggestBox, when handling the GotFocus or LostFocus methods, tapping the AutoSuggestBox causes e.NewFocusedElement and e.OldFocusedElement to be a TextBox (which is the ControlTemplate of AutoSuggestBox and receives the focus). As a result, when comparing the PlatformView with the appropriate handler in FocusManagerMapping, the condition is not satisfied, causing the focus and unfocus events to not work correctly.

Description of Change

• To address this, I have specifically handled the focus and unfocus events for AutoSuggestBox in SearchBarHandler.Windows.

Regressed PR

• [Windows] Handle focus events using FocusManager (take 2) #24695

Issues Fixed

Fixes #28419

Tested the behaviour in the following platforms

• Android
• Windows
• iOS
• Mac

Screenshot

Before Issue Fix	After Issue Fix
SearchBarIssueVideo.mp4	SearchBarFixVideo.mp4

[dotnet-policy-service]

Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[mattleibow]

I know you are not done yet, but we do lose the logic in the UpdateIsFocused method in the manager. Maybe that method should be private protected and we use that?

[Ahamed-Ali]

I know you are not done yet, but we do lose the logic in the UpdateIsFocused method in the manager. Maybe that method should be private protected and we use that?

Yes, I have now utilized UpdateIsFocused method from ViewHandler.Windows to preserve the existing logic. Please let me know if you have any other concerns. @mattleibow

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

Good comment!

I was wondering if we could improve the logic in ViewHandler.Windows to manage the focus, and if comparing also based on derived types would make sense, even though AutoSuggestBox doesn't derive from Textbox (it does from ItemsControl). So, I think changes are fine.