-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements SecureStorage.GetOrSetAsync(key, value?)
(for #27966)
#28565
Open
scarletquasar
wants to merge
5
commits into
dotnet:main
Choose a base branch
from
scarletquasar:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dotnet-policy-service agree |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Mar 24, 2025
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
reviewed
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-essentials
Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info
community ✨
Community Contribution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR addresses a recently created issue that suggests the creation of the method
SecureStorage.GetOrSetAsync(key, value?)
that is focused in providing an easy interface to work with various operations that involve retrieving data from SecureStorage when there is not guarantee that the data already exists, allowing the developer to set a default value directly inside the operation chain instead of creating if statements and checks.Usage example:
Current (unoptimized) way to achieve the same result today:
Public API Changes
Issues Fixed
#27966 - To https://github.com/dotnet/maui/milestone/14
Extra Statements
Shipped
files with the public API changes, I didn't find more documentation about how properly deal with that and I can change my PR based on the next comments;