Fixed a NullReferenceException when starting application with empty shell on Windows #28879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
jsuarezruiz
reviewed
Apr 10, 2025
| @@ -193,6 +193,12 @@ public override bool Equals(object obj) => | |||
|
|
|||
| internal void SwitchShellItem(ShellItem newItem, bool animate = true) | |||
| { | |||
| if (newItem is null) | |||
There was a problem hiding this comment.
What's the behavior on other platforms? Would be nice to align the behavior and throw the same exception with the same message if possible.
There was a problem hiding this comment.
@jsuarezruiz, On Android, the empty Shell throws a similar exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
A NullReferenceException is thrown when starting the application with an empty shell on Windows.
Root Cause
The shell does not have any items, so the shell item is null. In the source code, a null check was not implemented.
Description of Change
Throws an InvalidOperationException when the Shell item or the current Shell item is null.
Reference
Ensured consistent behavior with Android by referring to the following code.
maui/src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellItemRenderer.cs
Line 79 in 6ff7573
Validated the behavior in the following platforms
Issues Fixed
Fixes #21562
Output ScreenShot
BeforeFix.3.mp4
After-Fix-1.mp4