Fix for Android - Dynamic Updates to CollectionView Header/Footer and Templates Are Not Displayed #28904
+453
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
added
the
area-controls-collectionview
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Apr 22, 2025
| } | ||
|
|
||
| [Test, Order(4)] | ||
| public void CollectionViewFooterViewShouldChangeDynamically() |
There was a problem hiding this comment.
This tests are failing on iOS:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2404
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2421
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 665
at Microsoft.Maui.TestCases.Tests.Issues.Issue28676.CollectionViewFooterViewShouldChangeDynamically() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28676.cs:line 47
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
| @@ -33,12 +33,13 @@ protected override void ItemsViewPropertyChanged(object sender, PropertyChangedE | |||
| { | |||
| base.ItemsViewPropertyChanged(sender, property); | |||
|
|
|||
| if (property.Is(Microsoft.Maui.Controls.StructuredItemsView.HeaderProperty)) | |||
| if (property.Is(Microsoft.Maui.Controls.StructuredItemsView.HeaderProperty) || property.Is(Microsoft.Maui.Controls.StructuredItemsView.HeaderTemplateProperty)) | |||
There was a problem hiding this comment.
The test HeaderFooterTemplateWorks is failing on Android, could you verify if is related with the changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
HeaderTemplateandFooterTemplateare also not applied correctly at runtime.Root Cause:
ItemsViewPropertyChangeddid not handle updates forHeaderTemplatePropertyandFooterTemplateProperty.OnBindViewHolderdid not account for rendering updated header/footer content or templates.Description of Change
HeaderTemplatePropertyandFooterTemplatePropertyin theItemsViewPropertyChangedmethod to ensure runtime changes are detected and processed.OnBindViewHoldermethod to handle both simple views and string-based headers/footers using SimpleViewHolder.BindTemplatedItemViewHolderto correctly create and bind TemplatedItemViewHolder for HeaderTemplate and FooterTemplate, ensuring updates are accurately reflected in the UI.Issues Fixed
Fixes #28676
Tested the behaviour on the following platforms
Output Screenshot
HeaderFooterBefore.mov
HeaderFooterFix.mov