Skip to content

[Windows] Fix for IndicatorView using templated icons not working #28905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Windows] Fix for IndicatorView using templated icons not working #28905

wants to merge 9 commits into from

Conversation

SyedAbdulAzeemSF4852
Copy link
Contributor

Issue Details

  • When defining a data template in the IndicatorView, the data template is not applied, and instead, a circle shape is displayed.

Root Cause

  • Once the indicator's view data template is updated, the shapes are also being applied, which overrides the data template and displays the shapes instead.

Description

  • If a data template is specified, then skipped the creation of shapes and the updating of indicator colors.

Validated the behaviour in the following platforms

  • Windows
  • Android
  • iOS
  • Mac

Issues Fixed

Fixes #7144

Output

Before After

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Apr 10, 2025
@jsuarezruiz jsuarezruiz added area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/windows 🪟 labels Apr 10, 2025
jsuarezruiz
jsuarezruiz reviewed Apr 10, 2025
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7144.cs
public void IndicatorViewWithTemplatedIcon()
{
App.WaitForElement("descriptionLabel");
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots in all platforms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz , I've attached the screenshots for the Android and iOS platforms. I will add the screenshots for the other platforms in the next CI run​.

@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 force-pushed the fix-7144 branch 2 times, most recently from 434dece to 3ae6618 Compare April 11, 2025 10:46
@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 marked this pull request as ready for review April 11, 2025 13:24
@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 requested a review from a team as a code owner April 11, 2025 13:24
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] [Scenario Day] IndicatorView using templated icons not working
2 participants
@SyedAbdulAzeemSF4852 @jsuarezruiz