[X] Protect some xmlns #28909
Open
[X] Protect some xmlns #28909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -336,16 +336,24 @@ static IValueNode GetValueNode(object value, XmlReader reader) | |||
| static void GatherXmlnsDefinitionAttributes() | |||
| { | |||
| Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies(); | |||
| s_xmlnsDefinitions = new List<XmlnsDefinitionAttribute>(); | |||
| s_xmlnsDefinitions = []; | |||
There was a problem hiding this comment.
Using [] to initialize s_xmlnsDefinitions is not valid in C#. Please replace it with a proper List initialization, e.g., 'new List();'.
Suggested change
| s_xmlnsDefinitions = []; | |
| s_xmlnsDefinitions = new List<XmlnsDefinitionAttribute>(); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
protect maui and x: xmlns from overloading. - fixes #28836
StephaneDelcroix
force-pushed
the
dev/stdelc/protectxmlns
branch
from
ddcb498 to
6613043
Compare
|
😉 |
MartyIX
reviewed
Apr 11, 2025
| @@ -26,14 +27,24 @@ static IList<XmlnsDefinitionAttribute> GatherXmlnsDefinitionAttributes(ModuleDef | |||
| if (ca.AttributeType.FullName == typeof(XmlnsDefinitionAttribute).FullName) | |||
| { | |||
| var attr = GetXmlnsDefinition(ca, asmDef); | |||
| //maui, and x: xmlns are protected | |||
| if (attr.XmlNamespace.StartsWith("http://schemas.microsoft.com/", StringComparison.OrdinalIgnoreCase) && | |||
There was a problem hiding this comment.
Would using https:// instead of http:// allow me to bypass this check?
I'm not exactly sure if this is supposed to be a hard check or a soft check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[X] Protect some xmlns
protect maui and x: xmlns from overloading.
Issues Fixed