Skip to content

Compute LayoutConstraints on new *StackLayout and Grid #28931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compute LayoutConstraints on new *StackLayout and Grid #28931

wants to merge 1 commit into from

Conversation

albyrock87
Copy link
Contributor

Description of Change

Preparing to make a real performance impact with #28479 and other upcoming changes aiming to reduce layout passes.

Relates to #28897

@albyrock87 albyrock87 requested a review from a team as a code owner April 11, 2025 09:54
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 11, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @@albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@albyrock87 albyrock87 force-pushed the stack-layout-constraints branch from 8b49c06 to 7cd954d Compare April 11, 2025 10:10
@albyrock87 albyrock87 marked this pull request as draft April 11, 2025 11:28
@albyrock87 albyrock87 force-pushed the stack-layout-constraints branch from 7cd954d to a9231f3 Compare April 11, 2025 11:51
@albyrock87 albyrock87 changed the title Compute LayoutConstraints on new *StackLayout Compute LayoutConstraints on new *StackLayout and Grid Apr 11, 2025
@albyrock87 albyrock87 marked this pull request as ready for review April 11, 2025 11:52
@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR7 milestone Apr 11, 2025
@albyrock87
Copy link
Contributor Author

Broken UITests pass on my machine.

@jsuarezruiz jsuarezruiz added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf) labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter community ✨ Community Contribution t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)
Projects
MAUI SDK Ongoing
Status: Todo
Milestone
.NET 9 SR7
Development

Successfully merging this pull request may close these issues.
4 participants
@albyrock87 @rmarinho @PureWeen @jsuarezruiz