Fixed the OnPlatform does not work for header property in Collection view #28935
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
| @@ -224,6 +224,17 @@ internal static object ConvertTo(this object value, Type toType, Func<TypeConver | |||
| } | |||
| } | |||
|
|
|||
| // When toType is object and value is OnPlatform<T>, we need to return the wrapped value from IWrappedView | |||
There was a problem hiding this comment.
The comment references 'IWrappedView' while the code uses 'IWrappedValue'. Consider updating the comment to avoid confusion.
Suggested change
| // When toType is object and value is OnPlatform<T>, we need to return the wrapped value from IWrappedView | |
| // When toType is object and value is OnPlatform<T>, we need to return the wrapped value from IWrappedValue |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
jsuarezruiz
added
the
area-controls-collectionview
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Apr 15, 2025
| public void ShouldDisplayHeaderBasedOnOnPlatform() | ||
| { | ||
| App.WaitForElement("CollectionView"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots. Already available in the latest build.
Example, Mac:
Could you commit the images?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
When setting OnPlatform for the Header property in the CollectionView, the exact value of the Header property is not displayed.
Root Cause
When OnPlatform is set for the Header property in the CollectionView, the exact T value is not retrieved from the ApplyPropertiesVisitors.
Description of Changes
Retrieve the actual value from the IWrappedValue of the wrapped value, and return it instead of the OnPlatform type itself.
Fixes #25124
Validated the behaviour in the following platforms
Output images:
Android
iOS
macOS
Windows