[Android]Fix: Swapping out the content of a RefreshView breaks on Android #28944
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure proper rendering
|
Hey there @@bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
requested changes
Apr 14, 2025
|
@jsuarezruiz could you run pipelines? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This issue occurs because
SwipeRefreshLayoutonly lays out its child view when its own dimensions change. When new content is set dynamically and the container hasn't resized,_contentViewis never measured or positioned, resulting in blank rendering.The fix explicitly calls
Layout(...)on_contentViewduringOnLayout, ensuring it is properly positioned even if the container size hasn't changed.before_fix.mov
after_fix.mov
Issues Fixed
Fixes #28361