Fix for ItemSpacing value being retained when re-entering CollectionView with ItemsLayout set to vertical or horizontal list after navigating back. #29190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rItemsLayout instances with new ones in initialization and converter to avoid outdated ItemSpacing on back and GoToAsync navigation.
|
Hey there @@BagavathiPerumal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
jsuarezruiz
added
the
area-controls-collectionview
jsuarezruiz
reviewed
Apr 25, 2025
| App.Tap("PopButton"); | ||
| App.WaitForElement("NavigatedPageButton"); | ||
| App.Tap("NavigatedPageButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots on Mac and Windows.
There was a problem hiding this comment.
Snapshots already available in the latest build.
Could you commit the images?
There was a problem hiding this comment.
@jsuarezruiz, I have successfully added snapshots for Mac and Windows.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Apr 28, 2025
| App.Tap("PopButton"); | ||
| App.WaitForElement("NavigatedPageButton"); | ||
| App.Tap("NavigatedPageButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Snapshots already available in the latest build.
Could you commit the images?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The issue was caused because LinearItemsLayout.Vertical and LinearItemsLayout.Horizontal were used as static instances instead of creating new instances in the layout type converter. As these static instances were reused, properties like ItemSpacing retained their previous values when returning to the page using PopAsync. Since the internal items layout property defaulted to the static LinearItemsLayout.Vertical, the layout did not refresh properly, leading to inconsistent or unexpected behavior across all platforms.
Description of Issue Fix
The fix involves replacing the use of static instances (LinearItemsLayout.Vertical and LinearItemsLayout.Horizontal) with newly created instances of LinearItemsLayout to prevent shared state across navigations. This was achieved by updating the layout initialization to use a defaultValueCreator that returns a new LinearItemsLayout instance, and modifying the ItemsLayoutTypeConverter to return new instances based on the orientation string, rather than reusing static ones. This ensures each layout has its own settings, so ItemSpacing doesn't carry over when the page is popped with the back button and opened again using GoToAsync.
Tested the behavior in the following platforms.
Issues Fixed
Fixes #28023
Output
Beforefix-ItemsSpacing.mov
Afterfix-ItemsSpacing.mov