-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Testing] Fix for UITest Catalyst screenshot dimension inconsistency and image cropping issue #29204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Testing] Fix for UITest Catalyst screenshot dimension inconsistency and image cropping issue #29204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the legacy workaround for handling Mac Catalyst full-screen mode in the ScrollView UI tests. The changes aim to improve screenshot consistency by eliminating the conditional full-screen mode code.
- Removed conditional full-screen mode adjustments in three test methods.
- Ensured tests now rely on the updated screenshot capture mechanism.
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/ScrollViewUITests.cs:24
- Ensure that the removal of the full-screen workaround is fully validated by updated CI screenshots, as the tests now rely on the updated screenshot mechanism to maintain consistent dimensions.
#if MACCATALYST
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This PR removes the previous workaround for handling Mac Catalyst screenshots in full-screen mode, as the underlying screenshot capture mechanism has been improved.
Issue
Screenshot verification tests for Mac Catalyst were inconsistent due to some test cases running in full-screen mode while others didn't. This was happening because:
App.EnterFullScreen
was called in one of the ScrollView test cases.Solution