Skip to content

[Windows] Fix for ImagePaint Not rendering in View #29205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Windows] Fix for ImagePaint Not rendering in View #29205

wants to merge 3 commits into from

Conversation

HarishwaranVijayakumar
Copy link
Contributor

Root Cause of the issue

  • The code used an incorrect type reference: PlatformImage, which caused a compile-time due to missing namespace resolution.

Description of Change

  • Updated SetFillPaint in PlatformCanvas to address a platform-specific issue by explicitly referencing Platform.PlatformImage for proper image rendering on windows.

Issues Fixed

Fixes #28725

Test Case

Tested the behaviour in the follwing platforms

  • - Windows
  • - Android
  • - iOS
  • - Mac

Output

Before Fix After Fix

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 25, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 25, 2025
jsuarezruiz
jsuarezruiz requested changes Apr 28, 2025
View reviewed changes
src/Graphics/src/Graphics/Platforms/Windows/PlatformCanvas.cs
@@ -390,7 +390,7 @@ public override void SetFillPaint(Paint paint, RectF rectangle)

if (paint is ImagePaint imagePaint)
{
if (imagePaint.Image is PlatformImage image)
if (imagePaint.Image is Platform.PlatformImage image)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz, I have added a test case

@HarishwaranVijayakumar HarishwaranVijayakumar marked this pull request as ready for review April 28, 2025 11:05
@HarishwaranVijayakumar HarishwaranVijayakumar requested a review from a team as a code owner April 28, 2025 11:05
@jsuarezruiz
Copy link
Contributor

/azp run MAUI-UITests-public

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] ImagePaint is not rendering in View
2 participants
@HarishwaranVijayakumar @jsuarezruiz