Updating FlyoutPage layout when parent window size changes #29209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… item is clicked in ListView context menu. Checking PopoverPresentationController for null, it seems to be null checked already in all other places.
…not be called when overridden in derived class
…uestionable OnSizeChanged handler
|
Hey there @@VitalyKnyazev! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
requested changes
Apr 28, 2025
| DeviceDisplay.MainDisplayInfoChanged -= OnMainDisplayInfoChanged; | ||
| } | ||
| else | ||
| { | ||
| DeviceDisplay.MainDisplayInfoChanged += OnMainDisplayInfoChanged; | ||
| Window.SizeChanged += OnWindowOnSizeChanged; |
There was a problem hiding this comment.
Should unsubscribe from this event at some point.
There was a problem hiding this comment.
Updated code to unsubscribe from Window.SizeChanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Tracking parent window size change and update FlyoutPage layout using already existing mechanism.
Issues Fixed
Fixes #29032