[Windows] Fix CarouselView EmptyView display when filtering to zero items #29247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
sheiksyedm
added
area-controls-collectionview
jsuarezruiz
requested changes
Apr 30, 2025
| { | ||
| App.WaitForElement("FilterButton"); | ||
| App.Tap("FilterButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshot on Mac.
| _loopableCollectionView.IsLoopingEnabled = true; | ||
| } | ||
|
|
||
| ListViewBase.ItemTemplate = CarouselItemsViewTemplate; |
There was a problem hiding this comment.
Only update ItemTemplate when the value are actually changing, which reduces unnecessary UI updates and potential visual glitches.
var targetTemplate = isEmpty ? null : CarouselItemsViewTemplate;
if (ListViewBase.ItemTemplate != targetTemplate)
{
ListViewBase.ItemTemplate = targetTemplate;
}
There was a problem hiding this comment.
@jsuarezruiz, I have updated the code section based on your suggestions.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
On Windows platforms, both the empty view and a carousel item are displayed simultaneously when a search returns no results.
Root Cause
When filtering results to zero items in CarouselView on Windows, the handler correctly sets the EmptyView to visible but does not fully reset the current item state. As a result, both the empty view and the last carousel item remain visible.
Description of Change
Set the ItemTemplate as null and disables looping to ensure the UI is properly cleared when displaying the empty view.
Validated the behavior in the following platforms
Issues Fixed
Fixes #7150
Output ScreenShot
BeforeFix-7150.mp4
AfterFix-7150.mp4