[Android & iOS]Make SearchHandler's Focus() and Unfocus() work #29278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
reviewed
May 1, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
MartyIX
reviewed
May 1, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
MartyIX
reviewed
May 1, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs
Outdated
Show resolved
Hide resolved
PureWeen
requested changes
May 1, 2025
| _editText.ClearFocus(); | ||
| if (_editText.IsSoftInputShowing()) | ||
| { | ||
| _editText.HideSoftInput(); |
There was a problem hiding this comment.
I don't think we should hide this by default
If users want the keyboard to hide they can use the keyboard API to do this.
If we leave this as a side effect then there's not really a way for users to opt out
There was a problem hiding this comment.
Hmm.. Does the same should apply to Foucs() as well ? Because I'm currently calling an extension method which forces the keyboard to show.
jsuarezruiz
requested changes
May 2, 2025
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29277.cs
Outdated
Show resolved
Hide resolved
|
The same fix has already been included in PR - #28186 |
Sorry I missed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
iOS
iOS_Before_fix.mov
iOS_After_fix.mov
Android
Android_Before_fix.mov
Android_after_fix.mov
Issues Fixed
Fixes #29277