[Shell] Changed TitleProperty From TwoWay to OneWay #29280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the binding mode for the TitleProperty from TwoWay to OneWay to correct an apparent typo.
- Updated the TitleProperty binding mode to OneWay
- Aims to fix unintended behavior related to two-way binding in Shell item titles
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Shell/BaseShellItem.cs:54
- Changing the binding mode for a public API property (TitleProperty) from TwoWay to OneWay could be a breaking change and might affect consumers relying on two-way updates. Please ensure that adequate tests are in place, and update the public documentation accordingly.
BindableProperty.Create(nameof(Title), typeof(string), typeof(BaseShellItem), null, BindingMode.OneWay, propertyChanged: OnTitlePropertyChanged);
kubaflo
added
platform/android 🤖
platform/iOS 🍎
area-controls-shell
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
It looks like this might be a typo—
TwoWaybinding may not be necessary here, but please correct me if I'm mistaken.Issues Fixed
Fixes #29275