Remove Compatibility.Layout as a subclass of all modern .NET MAUI controls #29281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/breaking 💥
area-layout
|
🚨 API change(s) detected @davidbritch FYI |
|
@albyrock87 can't add you as a reviewer, so tagging you like this. Would be great to get your perspective here! |
jfversluis
commented
May 1, 2025
jsuarezruiz
previously approved these changes
May 2, 2025
jfversluis
force-pushed
the
remove-compat-layout-net10
branch
from
c4000a5 to
a3468ba
Compare
albyrock87
reviewed
May 2, 2025
There was a problem hiding this comment.
Why are we keeping this class alive?
| @@ -12,7 +12,7 @@ namespace Microsoft.Maui.Controls | |||
| /// <include file="../../docs/Microsoft.Maui.Controls/RefreshView.xml" path="Type[@FullName='Microsoft.Maui.Controls.RefreshView']/Docs/*" /> | |||
| [ContentProperty(nameof(Content))] | |||
| [DebuggerDisplay("{GetDebuggerDisplay(), nq}")] | |||
| public partial class RefreshView : ContentView, IElementConfiguration<RefreshView>, IRefreshView, ICommandElement | |||
| public partial class RefreshView : ContentView, IElementConfiguration<RefreshView>, IRefreshView, ICommandElement, IClippedToBoundsElement | |||
There was a problem hiding this comment.
Why don't we implement IClippedToBoundsElement directly in TemplatedView so that this class gets it for free?
| @@ -31,7 +28,7 @@ public Rect LayoutAreaOverride | |||
| return; | |||
| _layoutAreaOverride = value; | |||
| // Dont invalidate here, we can relayout immediately since this only impacts our innards | |||
| UpdateChildrenLayout(); | |||
| InvalidateMeasure(); | |||
There was a problem hiding this comment.
I see this one is already obsolete in .NET9: can we remove the property completely?
[Obsolete]
public Rect LayoutAreaOverride
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR removes
Compatibility.Layoutas a subclass of all modern .NET MAUI controls. It simplifies the control hierarchy and layout system by removingCompatibility.Layoutfrom the middle of the hierarchy.Additionally, does some minor code clean up and moving docs to inline.
Issues Fixed
Fixes #28736