[Windows] Fix for CarouselView IsSwipeEnabled=False Prevents Visual Navigation #29286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where setting IsSwipeEnabled to false disables the visual scrollbar, preventing programmatic navigation in CarouselView. Key changes include updating scrollbar visibility to "Hidden" on Windows and adding corresponding tests to ensure the fix works across platforms.
- Updated CarouselViewHandler.Windows.cs to use WScrollBarVisibility.Hidden instead of Disabled when IsSwipeEnabled is false.
- Added a test for the issue in TestCases.Shared.Tests.
- Updated TestCases.HostApp to host the revised CarouselView behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29216.cs | Added test case to verify CarouselView scrolling behavior. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29216.cs | Integrated test UI for CarouselView navigation. |
| src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs | Modified scrollbar visibility handling to resolve the scrolling bug. |
jsuarezruiz
added
platform/windows 🪟
area-controls-collectionview
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
RootCause:
Setting IsSwipeEnabled = false disables scrollbar visibility, which prevents the CarouselView from scrolling when position changed programmatically.
Description of Change:
Using hidden for the scrollbar visibility instead of disabled resolves the issue and enables programmatic scrolling to function correctly.
Issues Fixed
Fixes #29216
Tested the behavior in the following platforms
Screenshot
Issue29216BeforeFix.mp4
Issue29216AfterFix.mp4