-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Glide IllegalArgumentException in MauiCustomTarget.clear() for destroyed activities #29780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+32
−0
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9da158c
Initial plan for issue
Copilot 75a0749
Add context destruction checks to prevent Glide IllegalArgumentException
Copilot 9440b1e
Address code review feedback: remove duplication, add logging, simpli…
Copilot b28e6fb
Replace android.util.Log.w with PlatformLogger and add comprehensive …
Copilot b25b1f5
Replace Java tests with C# DeviceTests for context destruction scenarios
Copilot 12a28f2
Fix C# test structure: move tests inside ImageTests class
Copilot ac11d70
Remove nonsensical tests and build.gradle changes that don't test des…
Copilot 85bf1d2
Add verbose logging when context destruction skips Glide clear operation
Copilot c9bcc25
Add curly braces around verbose logging if statement
Copilot bb8728d
Fix Java visibility: make isContextDestroyed method public for cross-…
Copilot 6fcb190
Simplify context destruction check to match Glide's implementation an…
Copilot 5be89b1
Remove blank line from import section in PlatformInterop.java
Copilot 747dd02
Reduce PR scope to only fix MauiCustomTarget.clear() crash
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.