-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS, Mac] Fix for RadioButton TextColor for plain Content not working #31940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[iOS, Mac] Fix for RadioButton TextColor for plain Content not working #31940
Conversation
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
} | ||
} | ||
|
||
class ContentLabel : Label { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can include a comment here?
Internal label type used by ContentPresenter to avoid interference from global Label styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz, I have added a comment.
} | ||
|
||
static Label ConvertToLabel(string textContent, ContentPresenter presenter) | ||
static ContentLabel ConvertToLabel(string textContent, ContentPresenter presenter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include a related tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz, Tried to add test using Application.Current.Resources, but it breaks the other test cases.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #18011
Tested the behaviour in the following platforms
Output